-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Inline Field data overflowing on Kanban cards #6020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Added
maxWidth
property to multiple display components to prevent text overflow on Kanban cards - Updated hooks to include
maxWidth
in the context and return it - Modified
RecordInlineCellDisplayMode.tsx
to usedisplay: flex;
for better alignment - Adjusted
EllipsisDisplay.tsx
to append 'px' tomaxWidth
value - Enhanced
RoundedLink.tsx
andEntityChip.tsx
with newmaxWidth
prop for better overflow handling
18 file(s) reviewed, 1 comment(s)
packages/twenty-front/src/modules/ui/field/display/components/EllipsisDisplay.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Ensured
maxWidth
property prevents data overflow on Kanban cards - Modified
max-width
CSS property to conditionally append 'px' - Improved handling of
maxWidth
prop for better UI consistency
1 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This masWidth approach is working but I wonder if we can find a simpler solution that would avoid passing maxWidth.
Let's discuss this with @lucasbordeau tomorrow
Sure, let me know if there is a simpler solution, will change the implementaion, although I tried and unable to make it work, also some ellipsis implementation on other pages in this codebase, they were also passing max width from props. |
Closing this PR as it has already been fixed by a recent change. Also for reference, this approach is not optimal as we should only rely on CSS for detecting the container width and not telling it max width. We have it in the codebase but ideally we shouldn't. |
For reference this issue was fixed by #6061 |
Fixes: #6000