Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Inline Field data overflowing on Kanban cards #6020

Closed
wants to merge 9 commits into from

Conversation

rksingh2001
Copy link
Contributor

Fixes: #6000
image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added maxWidth property to multiple display components to prevent text overflow on Kanban cards
  • Updated hooks to include maxWidth in the context and return it
  • Modified RecordInlineCellDisplayMode.tsx to use display: flex; for better alignment
  • Adjusted EllipsisDisplay.tsx to append 'px' to maxWidth value
  • Enhanced RoundedLink.tsx and EntityChip.tsx with new maxWidth prop for better overflow handling

18 file(s) reviewed, 1 comment(s)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Ensured maxWidth property prevents data overflow on Kanban cards
  • Modified max-width CSS property to conditionally append 'px'
  • Improved handling of maxWidth prop for better UI consistency

1 file(s) reviewed, no comment(s)

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This masWidth approach is working but I wonder if we can find a simpler solution that would avoid passing maxWidth.

Let's discuss this with @lucasbordeau tomorrow

@rksingh2001
Copy link
Contributor Author

This masWidth approach is working but I wonder if we can find a simpler solution that would avoid passing maxWidth.

Let's discuss this with @lucasbordeau tomorrow

Sure, let me know if there is a simpler solution, will change the implementaion, although I tried and unable to make it work, also some ellipsis implementation on other pages in this codebase, they were also passing max width from props.

@lucasbordeau
Copy link
Contributor

Closing this PR as it has already been fixed by a recent change.

Also for reference, this approach is not optimal as we should only rely on CSS for detecting the container width and not telling it max width.

We have it in the codebase but ideally we shouldn't.

@rksingh2001 rksingh2001 deleted the #6000 branch July 1, 2024 16:18
@lucasbordeau
Copy link
Contributor

For reference this issue was fixed by #6061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline Field data overflowing on Kanban cards
3 participants