-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated MessageChannelSyncStatus enum: changed COMPLETED to ACTIVE #5965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Renamed
MessageChannelSyncStatus.COMPLETED
toACTIVE
- Updated references to
COMPLETED
status throughout the codebase
1 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Renamed
COMPLETED
status toACTIVE
inMessageChannelSyncStatus
enum - Updated database command to reflect the new
ACTIVE
status - Modified field metadata options to include
ACTIVE
status - Ensured consistency in naming convention across database and application logic
2 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated
MessageChannelSyncStatus
enum: changedCOMPLETED
toACTIVE
- Modified
markAsCompletedAndSchedulePartialMessageListFetch
method to reflect the new status - Ensured correct status update in the message channel repository
1 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated
MessageChannelSyncStatus
enum: replacedCOMPLETED
withACTIVE
- Modified database schema to reflect new enum values
- Updated
syncStatus
field metadata inmessageChannel
table - Adjusted
updateSyncStatus
method logic inmessage-channel.repository.ts
2 file(s) reviewed, no comment(s)
Thanks for contributing @akarsanth :) Seems the ticket is already assigned to another contributor but the contributor has not raised a PR yet |
Hi @akarsanth Thanks for the PR! Could you create a command (see 0-20-update-message-channel-sync-status-enum.command for example) thats:
|
(and the command should be name as 0-21 now as we are preparing the 0.21 version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @akarsanth @bosiraphael :)
Thanks @akarsanth for your contribution! |
Fixes #5961