[Issue-5772] Add sort feature on settings tables #5787

Anand-Krishnan-M-J · 2024-06-09T16:26:20Z

Proposed Changes

Introduce a new custom hook - useTableSort to sort table content
Add test cases for the new custom hook
Integrate useTableSort hook on to the table in settings object and settings object field pages

Related Issue

#5772

Evidence

2024-06-09.21-35-41.mp4

Evidence after addressing review comments

2024-07-04.21-33-12.mp4

Further comments

Apologies for the large PR. Looking forward for the review

greptile-apps

PR Summary

Introduced useTableSort custom hook for table sorting
Added test cases for useTableSort
Integrated sorting in SettingsObjectFieldItemTableRow and SettingsObjectItemTableRow
Enabled clickable headers for sorting in TableHeader
Updated SettingsObjectDetail and SettingsObjects pages to use sorting functionality

packages/twenty-front/src/hooks/__tests__/useTableSort.test.ts

greptile-apps · 2024-06-09T16:27:00Z

packages/twenty-front/src/hooks/useTableSort.ts

+type SortConfig<T> = {
+  sortByColumnKey: keyof T;
+  sortOrder: sortOrders;
+};


Consider renaming sortOrders to SortOrders to follow TypeScript enum naming conventions.

greptile-apps · 2024-06-09T16:27:00Z

packages/twenty-front/src/hooks/useTableSort.ts

+        return order === sortOrders.ascending
+          ? (a[columnKey] as string).localeCompare(b[columnKey] as string)
+          : (b[columnKey] as string).localeCompare(a[columnKey] as string);
+      } else if (typeof a[columnKey] === 'number') {


Handle cases where a[columnKey] or b[columnKey] might be undefined to prevent runtime errors.

greptile-apps · 2024-06-09T16:27:20Z

...rc/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx

@@ -7,6 +7,7 @@ import { useGetRelationMetadata } from '@/object-metadata/hooks/useGetRelationMe
 import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
 import { getObjectSlug } from '@/object-metadata/utils/getObjectSlug';


Ensure fieldType is correctly populated in all instances of fieldMetadataItem.

greptile-apps · 2024-06-09T16:27:20Z

...rc/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx

@@ -41,10 +43,8 @@ const StyledIconTableCell = styled(TableCell)`
 export const SettingsObjectFieldItemTableRow = ({


Consider adding a default value or error handling for updateDataTypes to avoid potential runtime errors.

greptile-apps · 2024-06-09T16:27:38Z

...ont/src/modules/settings/data-model/object-details/components/SettingsObjectItemTableRow.tsx

 import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
 import { useIcons } from 'twenty-ui';

 import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
 import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
 import { SettingsDataModelObjectTypeTag } from '@/settings/data-model/objects/SettingsDataModelObjectTypeTag';
-import { getObjectTypeLabel } from '@/settings/data-model/utils/getObjectTypeLabel';
+import {
+  getObjectTypeLabel,


Ensure useEffect dependency array is correct to avoid unnecessary re-renders.

greptile-apps · 2024-06-09T16:28:42Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjectDetail.tsx

@@ -1,7 +1,13 @@
-import { useEffect } from 'react';
+import { useCallback, useEffect, useState } from 'react';


Consider importing useCallback and useState from React in a single line for better readability.

greptile-apps · 2024-06-09T16:29:01Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx

@@ -38,13 +64,74 @@ const StyledH1Title = styled(H1Title)`
  margin-bottom: 0;


Ensure that instanceCountObj is correctly populated before using it in getRowData to avoid potential undefined values.

Anand-Krishnan-M-J · 2024-06-10T13:28:26Z

Hi Charles, Thanks a lot for your feedback. I will look in this and update the PR. Some immediate work has come up and I hope to fix this on the weekend.

…

On Mon, 10 Jun 2024, 5:11 pm Charles Bochet, ***@***.***> wrote: @Anand-Krishnan-M-J <https://github.com/Anand-Krishnan-M-J> Thanks for your PR :) Honnestly, I think we should restrict the scope to supporting Links filtering. Supporting sort in this PR (for Thursday) looks very ambitious. Let's treat that in a separated PR and keep this one for Links filtering 1. Please run npx nx run twenty-front:lint:ci, you should see some errors. (I believe they are tied to the changes you have made for sorting) 2. The work on Links looks good but I cannot test it as the front does not build at the moment 3. we'll have few lines to add in the backend to remove secondaryLinks from the FilterInput image.png (view on web) <https://github.com/twentyhq/twenty/assets/12035771/9b6f0909-8d3a-42d9-8f5d-58d696180fa6> — Reply to this email directly, view it on GitHub <#5787 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU4NDQEI4NO5BFCQ5D2SX6LZGWGG3AVCNFSM6AAAAABJBAMXOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJYGEYTKNRSGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

lucasbordeau

Thank you for contributing.

It's conceptually ok but some patterns feels odd, due to props drilling.

We use Recoil extensively in Twenty codebase and this feature particularly fits Recoil.

Could you please rework on a solution where :

Sorts are stored in a Recoil family state (you'll find many examples in our codebase) I suggest you make a family state with a key like { tableId: string, tableObjectName: string, tableFieldName: string } => value: OrderBy | null
The logic around a column header cell is abstracted in that header cell component and just modifies the related sort in the recoil family state
Then each list should just use a hook like useSortedArray that takes (arrayToSort: ObjectRecord[], tableId: string, tableObjectName: string and fieldName: string (or fieldName array string[]) and it applies the sort and just derives the state.

It will be much more simpler to read and maintain (and review ;) )

lucasbordeau · 2024-06-14T14:29:38Z

packages/twenty-front/src/hooks/useTableSort.ts

@@ -0,0 +1,62 @@
+import { useState } from 'react';
+
+enum sortOrders {


We already have OrderBy

Updated the type to OrderBy. thanks for pointing it out.

lucasbordeau · 2024-06-14T14:31:01Z

packages/twenty-front/src/hooks/useTableSort.ts

+      : sortOrders.ascending;
+  };
+
+  const handleSortClick = (columnKey: keyof T) => {


Handlers should be the scope of a component, not of a hook

Moved the logic inside component

lucasbordeau · 2024-06-14T14:32:24Z

packages/twenty-front/src/hooks/useTableSort.ts

+    sortConfig.sortOrder,
+  );
+
+  const toggleSortOrder = (sortOrder: sortOrders) => {


This function isn't toggling, it's just returning the opposite of the passed sortOrder, so it should either be renamed or either really toggling the state

Since the logic is moved to component, we no longer have toggleSortOrder()

lucasbordeau · 2024-06-14T14:33:11Z

...rc/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx

@@ -17,11 +18,12 @@ import { SettingsObjectFieldDataType } from './SettingsObjectFieldDataType';

 type SettingsObjectFieldItemTableRowProps = {
  ActionIcon: ReactNode;
-  fieldMetadataItem: FieldMetadataItem;
+  fieldMetadataItem: FieldMetadataItem & { fieldType: string | boolean };


fieldType is redundant, we already have a type property on fieldMetadataItem which should be used.

Removed the redundant field

lucasbordeau · 2024-06-14T14:34:55Z

...rc/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx

@@ -60,6 +60,18 @@ export const SettingsObjectFieldItemTableRow = ({

  const fieldType = fieldMetadataItem.type;
  const isFieldTypeSupported = isFieldTypeSupportedInSettings(fieldType);
+  useEffect(() => {


This logic is not necessary because we already have a fieldMetadataItem array higher up in the tree, the row shouldn't be related to this feature.

Removed the unwanted logic and used the actual value in higher level component instead

lucasbordeau · 2024-06-14T14:35:53Z

...rc/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx

-          !!identifierType &&
-          (identifierType === 'label' ? 'Record text' : 'Record image')}
-      </TableCell>
+      <TableCell>{fieldMetadataItem.fieldType}</TableCell>


We should be keep the derived state here, not adding a new field on fieldMetadataItem, if you need to share it with another place just create a util like getFieldMetadataItemTypeLabel(fieldMetadataItem)

Replaced with the derived state

Anand-Krishnan-M-J · 2024-07-02T19:50:09Z

Thank you for contributing.

It's conceptually ok but some patterns feels odd, due to props drilling.

We use Recoil extensively in Twenty codebase and this feature particularly fits Recoil.

Could you please rework on a solution where :

Sorts are stored in a Recoil family state (you'll find many examples in our codebase) I suggest you make a family state with a key like { tableId: string, tableObjectName: string, tableFieldName: string } => value: OrderBy | null

The logic around a column header cell is abstracted in that header cell component and just modifies the related sort in the recoil family state

Then each list should just use a hook like useSortedArray that takes (arrayToSort: ObjectRecord[], tableId: string, tableObjectName: string and fieldName: string (or fieldName array string[]) and it applies the sort and just derives the state.

It will be much more simpler to read and maintain (and review ;) )

Hi @lucasbordeau
I was wondering why we need to set the key as
{ tableId: string, tableObjectName: string, tableFieldName: string }

Can we keep the family state key simpler, like this?
{ tableId: string; initialFieldName: string }

**Example:**
export const tableSortFamilyState = createFamilyState<
  { fieldName: string; orderBy: OrderBy | null },
  { tableId: string; initialFieldName: string }
>({
  key: 'tableSortFamilyState',
  defaultValue: (({ initialFieldName }: { initialFieldName: string }) => ({
    fieldName: initialFieldName,
    orderBy: 'AscNullsLast',
  })) as unknown as {
    fieldName: string;
    orderBy: OrderBy | null;
  },
});

By using a key as an object comprising tableId and initialFieldName (since each sort is related to a table and has an initial default sort), the state value would be:

    {    fieldName: string;
         orderBy: OrderBy | null;
    }

Please let me know your thoughts on this

…tom hook

greptile-apps

PR Summary

(updates since last review)

Introduced useSortedArray hook for sorting table content (/packages/twenty-front/src/hooks/useSortedArray.ts)
Removed useTableSort hook and its test cases (/packages/twenty-front/src/hooks/useTableSort.ts, /packages/twenty-front/src/hooks/__tests__/useTableSort.test.ts)
Added Recoil state for managing table sort states (/packages/twenty-front/src/modules/activities/states/tabelSortFamilyState.ts)
Integrated sorting functionality into SettingsObjectFieldItemTableRow and SettingsObjectItemTableRow components (/packages/twenty-front/src/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx, /packages/twenty-front/src/modules/settings/data-model/object-details/components/SettingsObjectItemTableRow.tsx)
Updated SettingsObjectDetail and SettingsObjects pages to use new sorting feature (/packages/twenty-front/src/pages/settings/data-model/SettingsObjectDetail.tsx, /packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx)

_{9 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings}

packages/twenty-front/src/hooks/__tests__/useSortedArray.test.tsx

packages/twenty-front/src/hooks/useSortedArray.ts

packages/twenty-front/src/modules/activities/states/tabelSortFamilyState.ts

greptile-apps · 2024-07-04T15:50:32Z

packages/twenty-front/src/modules/activities/states/tabelSortFamilyState.ts

+  TableSortFamilyKey
+>({
+  key: 'tableSortFamilyState',
+  defaultValue: getDefaultTableSortState as unknown as TableSortState,


🪶 style: Casting getDefaultTableSortState as unknown and then TableSortState may hide potential type issues. Consider refining the type definitions.

It feels a bit odd, I'm not sure what you're trying to do here? Assigning a function as default value?

Anand-Krishnan-M-J · 2024-07-04T15:56:59Z

Hey @lucasbordeau
Thanks for the detailed review and I have updated the PR.

I am still getting used to the Recoil pattern.
I come from more of a Redux - Saga pattern. Apologies for the trouble
Please let me know if there are still some weird things.

greptile-apps

PR Summary

(updates since last review)

Added useSortedArray hook for sorting table content (/packages/twenty-front/src/hooks/useSortedArray.ts)
Introduced test cases for useSortedArray hook (/packages/twenty-front/src/hooks/__tests__/useSortedArray.test.tsx)
Corrected type casting in tableSortFamilyState.ts (/packages/twenty-front/src/modules/activities/states/tableSortFamilyState.ts)
Integrated sorting functionality into SettingsObjectDetail.tsx (/packages/twenty-front/src/pages/settings/data-model/SettingsObjectDetail.tsx)
Added sorting feature to SettingsObjects.tsx (/packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx)

_{5 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

packages/twenty-front/src/hooks/useSortedArray.ts

FelixMalfait · 2024-07-17T07:16:53Z

...ont/src/modules/settings/data-model/object-details/components/SettingsObjectItemTableRow.tsx

 }: SettingsObjectItemTableRowProps) => {
  const theme = useTheme();

  const { totalCount } = useFindManyRecords({
    objectNameSingular: objectItem.nameSingular,
  });
+  useEffect(() => {


Can you try getting rid of useEffect? https://react.dev/learn/you-might-not-need-an-effect

Let me find a way to do that. Probably I will have to create a global state to do that, as we have to store the data somewhere to actually use it higher up the React tree.

You can use a recoil family here also

FelixMalfait · 2024-07-17T07:20:13Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjectDetail.tsx

+  const SortIcon = ({ sortKey }: { sortKey: SortKeys }) => {
+    if (sortKey !== sortConfig.fieldName) return null;
+    return sortConfig.orderBy === 'AscNullsLast' ? (
+      <IconArrowUp size="14" />


We tried to avoid hardcoding size values like that, you can probably find examples in the code, getting the size from the theme directly. Also it feels like the arrow isn't perfectly positionned, it's a bit too closed to the name and not perfectly vertically aligned (a bit too high)

FelixMalfait · 2024-07-17T07:23:16Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx

@@ -38,13 +66,92 @@ const StyledH1Title = styled(H1Title)`
  margin-bottom: 0;
 `;

+const tableHeadings: TableHeading = [


Something feels inconsistent here, it should be tableHeadings: TableHeading[] or tableHeading: TableHeading ; I think the singular version is best because heading is a row

Feels like it should be TableFieldSortDefinition[] or something like that

FelixMalfait · 2024-07-17T07:29:46Z

I think the order doesn't match with the arrows direction :)

FelixMalfait · 2024-07-17T07:30:17Z

Otherwise really great PR! Thanks a lot for your work @Anand-Krishnan-M-J - sorry we took so long to review

FelixMalfait · 2024-07-17T07:35:11Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx

+  instancesCount = 'instancesCount',
+}
+type InstanceCountStateType = { [key: string]: number };
+type TableHeading = {


The developer experience you're creating for future sort use-cases isn't great, you have to redeclare types every time you want to add sort to a table. You're already duplicating some code between SettingsObjects and SettingsObjectDetail

packages/twenty-front/src/hooks/useSortedArray.ts

lucasbordeau · 2024-07-22T14:10:41Z

packages/twenty-front/src/hooks/useSortedArray.ts

+    order: OrderBy | null,
+  ): T[] => {
+    return data.sort((a: T, b: T) => {
+      if (typeof a[columnKey] === 'string') {


We shouldn't try to guess the type from JS since it can be unreliable. Instead we should give this hook metadata about our table so that it knows how to behave for each field

packages/twenty-front/src/hooks/useSortedArray.ts

packages/twenty-front/src/modules/activities/states/tableSortFamilyState.ts

lucasbordeau · 2024-07-22T14:20:51Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjectDetail.tsx

+      sortKey: SortKeys.dataType,
+    },
+  ];
+  const SortIcon = ({ sortKey }: { sortKey: SortKeys }) => {


This should be move in the component that handles the column heading, it should be abstracted down.

lucasbordeau · 2024-07-22T14:22:29Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx

@@ -29,7 +39,25 @@ import { Table } from '@/ui/layout/table/components/Table';
 import { TableHeader } from '@/ui/layout/table/components/TableHeader';
 import { TableSection } from '@/ui/layout/table/components/TableSection';
 import { UndecoratedLink } from '@/ui/navigation/link/components/UndecoratedLink';
-
+import { useSortedArray } from '~/hooks/useSortedArray';
+export enum SortKeys {


SortKeys should be more self-explanatory, I cannot understand at first glance what it talks about.

Is it AvailableSortFieldName ?

lucasbordeau · 2024-07-22T14:23:20Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx

@@ -38,13 +66,92 @@ const StyledH1Title = styled(H1Title)`
  margin-bottom: 0;
 `;

+const tableHeadings: TableHeading = [


Feels like it should be TableFieldSortDefinition[] or something like that

lucasbordeau · 2024-07-22T14:23:42Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx

 export const SettingsObjects = () => {
+  const [instanceCountObj, setInstanceCount] = useState<InstanceCountStateType>(


Naming contains abbreviation and is not consistent

lucasbordeau · 2024-07-22T14:23:55Z

packages/twenty-front/src/pages/settings/data-model/SettingsObjects.tsx

  const theme = useTheme();

  const { activeObjectMetadataItems, inactiveObjectMetadataItems } =
    useFilteredObjectMetadataItems();
  const { deleteOneObjectMetadataItem } = useDeleteOneObjectMetadataItem();
  const { updateOneObjectMetadataItem } = useUpdateOneObjectMetadataItem();
+  const getRowData = (objectMetaDataItems: ObjectMetadataItem[]) =>


getRowData is not self-explanatory enough

lucasbordeau · 2024-07-22T14:25:25Z

@Anand-Krishnan-M-J Keep up the good work, I did a extensive code review so that you can be more in line with our standards and the way we code at Twenty.

Anand-Krishnan-M-J · 2024-07-24T14:55:58Z

@lucasbordeau
Thank you for your detailed code review and for the encouragement. I will address all the points raised as soon as possible.
As I am currently managing a busy release schedule at work, I kindly ask you to bear with me for a little while longer.

lucasbordeau · 2024-07-25T09:26:38Z

@Anand-Krishnan-M-J Please take your time, otherwise if it's too much work we'll handle it and update you on the changes for reference so that you can be up-to-date and ready for the next one ! Anyway it's already great to have made the core changes.

Anand-Krishnan-M-J · 2024-07-28T10:33:14Z

@lucasbordeau
Thank you for understanding. Given the current time constraints and to avoid further delays in releasing this feature, please proceed with the updates. I will monitor the changes and learn from them to improve my future contributions.

…eneric table sort

github-actions · 2024-08-14T15:12:19Z

Thanks @Anand-Krishnan-M-J for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Add sort feature in settings page

e378ecf

greptile-apps bot reviewed Jun 9, 2024

View reviewed changes

Anand-Krishnan-M-J marked this pull request as draft June 9, 2024 16:46

FelixMalfait added the -PR: awaiting review label Jun 10, 2024

lucasbordeau requested changes Jun 14, 2024

View reviewed changes

lucasbordeau self-assigned this Jun 14, 2024

lucasbordeau added -PR: awaiting author and removed -PR: awaiting review labels Jun 14, 2024

Anand-Krishnan-M-J added 2 commits July 4, 2024 00:54

Add new family state for table sort, remove sort click logic from cus…

1c933eb

…tom hook

Remove unwanted reordering

53f3513

Anand-Krishnan-M-J marked this pull request as ready for review July 4, 2024 15:49

Anand-Krishnan-M-J requested a review from lucasbordeau July 4, 2024 15:49

greptile-apps bot reviewed Jul 4, 2024

View reviewed changes

Anand-Krishnan-M-J mentioned this pull request Jul 11, 2024

Ability to sort on setting tables #5772

Closed

Typo

25da00f

greptile-apps bot reviewed Jul 17, 2024

View reviewed changes

packages/twenty-front/src/hooks/useSortedArray.ts Outdated Show resolved Hide resolved

FelixMalfait reviewed Jul 17, 2024

View reviewed changes

lucasbordeau added 2 commits July 19, 2024 15:02

Merge branch 'main' into issue-5772

2a9e255

WIP

14f7ee5

lucasbordeau reviewed Jul 22, 2024

View reviewed changes

FelixMalfait mentioned this pull request Aug 7, 2024

Ability to search in fields/objects list #6566

Closed

FelixMalfait added -PR: awaiting review and removed -PR: awaiting author labels Aug 7, 2024

lucasbordeau added 13 commits August 13, 2024 10:38

Merge branch 'main' into issue-5772

51fba43

Refactor order by

bf00663

Refactored object settings and object settings detail page with new g…

ebb1f29

…eneric table sort

Fixed tests

e3559cb

Fixed tests for useSortedArray

3a6d509

Finished refactor

4d855e6

Cleaned

4e0a5a8

Fix

3f5a16c

Fixed initial sort and page container

14d4897

Fix

c5d7431

Fix

7644f9a

Fix

8e7ffad

Removed unused contexts

2a76f93

lucasbordeau approved these changes Aug 14, 2024

View reviewed changes

lucasbordeau added 2 commits August 14, 2024 16:42

Fix lint

56a7993

Fix ci

c3dc498

lucasbordeau merged commit 59e14fa into twentyhq:main Aug 14, 2024
10 of 11 checks passed

		@@ -7,6 +7,7 @@ import { useGetRelationMetadata } from '@/object-metadata/hooks/useGetRelationMe
		import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
		import { getObjectSlug } from '@/object-metadata/utils/getObjectSlug';

		@@ -41,10 +43,8 @@ const StyledIconTableCell = styled(TableCell)`
		export const SettingsObjectFieldItemTableRow = ({

		@@ -1,7 +1,13 @@
		import { useEffect } from 'react';
		import { useCallback, useEffect, useState } from 'react';

		@@ -38,13 +64,74 @@ const StyledH1Title = styled(H1Title)`
		margin-bottom: 0;

		@@ -0,0 +1,62 @@
		import { useState } from 'react';

		enum sortOrders {

		export const SettingsObjects = () => {
		const [instanceCountObj, setInstanceCount] = useState<InstanceCountStateType>(

[Issue-5772] Add sort feature on settings tables #5787

[Issue-5772] Add sort feature on settings tables #5787

Conversation

Anand-Krishnan-M-J commented Jun 9, 2024 • edited Loading

Proposed Changes

Related Issue

Evidence

Evidence after addressing review comments

Further comments

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jun 9, 2024

Choose a reason for hiding this comment

greptile-apps bot Jun 9, 2024

Choose a reason for hiding this comment

greptile-apps bot Jun 9, 2024

Choose a reason for hiding this comment

greptile-apps bot Jun 9, 2024

Choose a reason for hiding this comment

greptile-apps bot Jun 9, 2024

Choose a reason for hiding this comment

greptile-apps bot Jun 9, 2024

Choose a reason for hiding this comment

greptile-apps bot Jun 9, 2024

Choose a reason for hiding this comment

Anand-Krishnan-M-J commented Jun 10, 2024 via email

lucasbordeau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Anand-Krishnan-M-J Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Anand-Krishnan-M-J commented Jul 2, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jul 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Anand-Krishnan-M-J commented Jul 4, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FelixMalfait commented Jul 17, 2024

FelixMalfait commented Jul 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasbordeau commented Jul 22, 2024

Anand-Krishnan-M-J commented Jul 24, 2024

lucasbordeau commented Jul 25, 2024

Anand-Krishnan-M-J commented Jul 28, 2024

github-actions bot commented Aug 14, 2024

Anand-Krishnan-M-J commented Jun 9, 2024 •

edited

Loading

Anand-Krishnan-M-J Jul 4, 2024 •

edited

Loading