-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Kubernetes via Terraform and Manifests #5721
Support for Kubernetes via Terraform and Manifests #5721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Added Kubernetes deployments for server and database
- Introduced services for server and database
- Configured persistent volumes and claims for server and database
- Set up Ingress for external access
- Added Terraform configurations for Kubernetes resources
Oh nice thanks :). I've never done any Terraform so I'm not able to review this but I know some people will be happy to see this |
Thanks for adding this! It motivated me to get Twenty setup in my k3s cluster for testing. I ended up using the bjw-s App Template Helm Chart with many of the values you provided here in the manifests. Also, using Flux instead of Terraform. Had to define FRONT_BASE_URL due to this error:
Also, the service for twenty-postgres shows up as
Does anyone know if it's possible to change the postgres password without building a new docker image? It would make sense to put the postgres password and URL into secrets and call them with something like this (under each deployment):
Otherwise, everything appears to be running well. |
Thanks for your comment @sysaeon! The pg password caused a lot of trouble for me as well. I spent a few hours banging my head on my keyboard trying to get any value other than I had issues with the |
I'd just add, the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated
useTasks
hook to improve task fetching and filtering - Enhanced
useWorkspaceFromInviteHash
for better workspace invite handling - Modified
RecordTableCellContainer
to handle edit/display modes and hotkeys - Improved
useFindManyRecords
for efficient record fetching - Added
useHandleToggleColumnFilter
anduseHandleToggleColumnSort
for column filter/sort management
10 file(s) reviewed, no comment(s)
Good call! Most default cases like AWS EBS-CSI don't support I tried to convey in the README that storage is highly opinionated to the users environment and should be expected to be modified. I update this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Added Kubernetes deployment section using Terraform and manifests in
packages/twenty-website/src/content/developers/self-hosting/cloud-providers.mdx
- Included link to community-led documentation for Kubernetes deployment
- Added disclaimers for Render, RepoCloud, and Azure Container Apps documentation being community-led and potentially outdated
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Hey sorry we left this open for so long. |
Support for Kubernetes via Terraform and Manifests
Adding basic support for the following Kubernetes resources