-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework messaging modules #5710
Rework messaging modules #5710
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { Module } from '@nestjs/common'; | ||
|
||
@Module({ | ||
imports: [], | ||
providers: [], | ||
exports: [], | ||
}) | ||
export class MessagingBlocklistManagerModule {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this module used for? |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
import { Module } from '@nestjs/common'; | ||
|
||
import { AnalyticsModule } from 'src/engine/core-modules/analytics/analytics.module'; | ||
import { MessagingTelemetryService } from 'src/modules/messaging/services/telemetry/messaging-telemetry.service'; | ||
import { MessagingTelemetryService } from 'src/modules/messaging/common/services/messaging-telemetry.service'; | ||
|
||
@Module({ | ||
imports: [AnalyticsModule], | ||
providers: [MessagingTelemetryService], | ||
exports: [MessagingTelemetryService], | ||
}) | ||
export class MessagingTelemetryModule {} | ||
export class MessagingCommonModule {} |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we ok to merge it without this? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bosiraphael it's completely reworking it so I did not want to lose time here