connected account access token refresh cron #5706
Conversation
|
|
||
| await this.connectedAccountRepository.updateAccessTokenNeedsRefresh( | ||
| messageChannel.connectedAccountId, | ||
| workspaceId, | ||
| ); |
There was a problem hiding this comment.
Probably not the correct place to put this into, but couldnt find a better place so its not repeated in every single sync job. Let me know if you have any other idea.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
RefreshAccessTokenCronCommandsModuletocommand.module.ts - Introduced
accessTokenNeedsRefreshandaccessTokenRefreshedAtfields in seed data - Integrated
RefreshAccessTokenJobModuleintojobs.module.ts - Added new constants for access token fields in
standard-field-ids.ts - Implemented access token refresh logic in
ConnectedAccountRepositoryand related services
| @@ -0,0 +1,33 @@ | |||
| import { Inject } from '@nestjs/common'; | |||
There was a problem hiding this comment.
Consider adding a more descriptive comment about the purpose of this import.
| super(); | ||
| } | ||
|
|
||
| async run(): Promise<void> { |
There was a problem hiding this comment.
Handle potential errors from the messageQueueService.addCron call.
| @@ -59,6 +59,14 @@ export class GmailMessageListFetchJob | |||
| return; | |||
| } | |||
|
|
|||
| if (connectedAccount.accessTokenNeedsRefresh) { | |||
| this.logger.log( | |||
There was a problem hiding this comment.
Ensure that the log message provides enough context for debugging, such as including the timestamp.
| @@ -70,6 +70,14 @@ export class GmailFullMessageListFetchService { | |||
| return; | |||
| } | |||
|
|
|||
| if (connectedAccount.accessTokenNeedsRefresh) { | |||
| this.logger.log( | |||
There was a problem hiding this comment.
Ensure that the log message provides enough context for debugging, such as including the current state of the token.
|
Sorry @rostaklein, just saw your PR but we have this huge refactoring: #5710 |
solves #5632
This is a wild guess how it could look like, tested ant it seem to work :) Looking forward for the comments.