Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove else if on position calculation #5691

Merged
merged 1 commit into from
May 31, 2024
Merged

Remove else if on position calculation #5691

merged 1 commit into from
May 31, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented May 31, 2024

As title

greptile-apps[bot]
greptile-apps bot reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Refactored get-dragged-record-position.util.ts to replace 'else if' with separate 'if' statements
  • Improved readability and maintainability of position calculation logic
  • Ensured functionality remains unchanged for position calculation

@Weiko Weiko merged commit 9fd761d into main May 31, 2024
13 checks passed
@Weiko Weiko deleted the tt-avoid-else-if branch May 31, 2024 12:31
Weiko pushed a commit that referenced this pull request May 31, 2024
@thomtrp @Weiko
Remove else if on position calculation (#5691)
1766eb5 
As title

fix
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
@thomtrp
Remove else if on position calculation (twentyhq#5691)
fca7582 
As title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@Weiko Weiko Weiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomtrp @Weiko