Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remove favorite on opportunity delete #5686

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix remove favorite on opportunity delete #5686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...ges/twenty-front/src/modules/object-record/record-action-bar/hooks/useRecordActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,22 @@ export const useRecordActionBar = ({

const handleDeleteClick = useCallback(async () => {
callback?.();
selectedRecordIds.forEach((recordId) => {
const foundFavorite = favorites?.find(
(favorite) => favorite.recordId === recordId,
);
if (foundFavorite !== undefined) {
deleteFavorite(foundFavorite.id);
}
});
await deleteManyRecords(selectedRecordIds);
Comment on lines 92 to 101
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure deleteFavorite handles cases where the favorite might not exist or deletion fails.

}, [callback, deleteManyRecords, selectedRecordIds]);
}, [
callback,
deleteManyRecords,
selectedRecordIds,
favorites,
deleteFavorite,
]);

const handleExecuteQuickActionOnClick = useCallback(async () => {
callback?.();
Expand Down
Loading