Build empty state for remote tables #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Introduced an empty state placeholder for remote tables in
RecordTable.tsx - Added
recordTableIdparameter touseLoadRecordIndexTable.tsanduseRecordTableRecordGqlFields.ts - Modified
RecordTableBody.tsxto accepttableRowIdsas a prop - Added
RecordTableEmptyState.tsxcomponent for user-friendly empty state messages
| Icon={IconSettings} | ||
| title="Go to Settings" | ||
| variant={'secondary'} | ||
| onClick={() => () => navigate('/settings/integrations')} |
There was a problem hiding this comment.
Remove the extra arrow function to avoid unnecessary nesting: onClick={() => navigate('/settings/integrations')}.
thomtrp
force-pushed
the
tt-remote-table-empty-state
branch
from
bc6ca62
to
5f886e3
Compare
| const { tableRowIdsState } = useRecordTableStates(recordTableId); | ||
| const tableRowIds = useRecoilValue(tableRowIdsState); | ||
|
|
||
| const { loading } = useLoadRecordIndexTable( |
There was a problem hiding this comment.
RecordIndex is the parent page which loading either the RecordTable or the RecordBoard. We should not call a recordIndex hook within the table, the dependency is in the wrong way
There was a problem hiding this comment.
I am not sure to understand the changes here:
- why pass tableRowIds to RecordTableBody instead of using recoil state?
- why drilling recordTableId? wasn't it working before
The dependency is also in the wrong way between recordIndexTable and RecordTable (it's actually kind of anti-pattern in the code I remember)
thomtrp
force-pushed
the
tt-remote-table-empty-state
branch
from
5f886e3
to
9464b1d
Compare
charlesBochet
approved these changes
May 31, 2024
| isRemote: boolean; | ||
| }; | ||
|
|
||
| export const RecordTableEmptyState = ({ |
thomtrp
force-pushed
the
tt-remote-table-empty-state
branch
from
541e42b
to
ca2e6e9
Compare
Weiko
pushed a commit
that referenced
this pull request
May 31, 2024
Remote tables could be in an empty state because: - either we do not have data, which is normal - either the connexion is broken (issue with the server, table requires updates...) Apollo throws errors but these will quickly disappear and do not provide any tips to the user on how handle those. This PR adds a new empty state placeholder for remote objects, that will be display when the record list is empty. It will provide a link to the settings page. <img width="1512" alt="Capture d’écran 2024-05-30 à 11 49 33" src="https://github.com/twentyhq/twenty/assets/22936103/fc2dd3cc-e90b-4033-b023-83ac9ff2a70b">
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Remote tables could be in an empty state because: - either we do not have data, which is normal - either the connexion is broken (issue with the server, table requires updates...) Apollo throws errors but these will quickly disappear and do not provide any tips to the user on how handle those. This PR adds a new empty state placeholder for remote objects, that will be display when the record list is empty. It will provide a link to the settings page. <img width="1512" alt="Capture d’écran 2024-05-30 à 11 49 33" src="https://github.com/twentyhq/twenty/assets/22936103/fc2dd3cc-e90b-4033-b023-83ac9ff2a70b">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote tables could be in an empty state because:
Apollo throws errors but these will quickly disappear and do not provide any tips to the user on how handle those.
This PR adds a new empty state placeholder for remote objects, that will be display when the record list is empty. It will provide a link to the settings page.