[FE] Update remote table schema + refactor Tables list #5548
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { gql } from '@apollo/client'; | ||
|
|
||
| import { REMOTE_TABLE_FRAGMENT } from '@/databases/graphql/fragments/remoteTableFragment'; | ||
|
|
||
| export const SYNC_REMOTE_TABLE_SCHEMA_CHANGES = gql` | ||
| ${REMOTE_TABLE_FRAGMENT} | ||
| mutation syncRemoteTableSchemaChanges($input: RemoteTableInput!) { | ||
| syncRemoteTableSchemaChanges(input: $input) { | ||
| ...RemoteTableFields | ||
| } | ||
| } | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ import { useCallback } from 'react'; | |
| import { ApolloClient, useApolloClient, useMutation } from '@apollo/client'; | ||
|
|
||
| import { SYNC_REMOTE_TABLE } from '@/databases/graphql/mutations/syncRemoteTable'; | ||
| import { modifyRemoteTableFromCache } from '@/databases/utils/modifyRemoteTableFromCache'; | ||
| import { useApolloMetadataClient } from '@/object-metadata/hooks/useApolloMetadataClient'; | ||
| import { useFindManyObjectMetadataItems } from '@/object-metadata/hooks/useFindManyObjectMetadataItems'; | ||
| import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular'; | ||
|
|
@@ -12,6 +12,7 @@ import { | |
| SyncRemoteTableMutation, | ||
| SyncRemoteTableMutationVariables, | ||
| } from '~/generated-metadata/graphql'; | ||
| import { isDefined } from '~/utils/isDefined'; | ||
|
|
||
| export const useSyncRemoteTable = () => { | ||
| const apolloMetadataClient = useApolloMetadataClient(); | ||
|
|
@@ -23,7 +24,6 @@ export const useSyncRemoteTable = () => { | |
| const { findManyRecordsQuery: findManyViewsQuery } = useFindManyRecordsQuery({ | ||
| objectNameSingular: CoreObjectNameSingular.View, | ||
| }); | ||
| const [mutate] = useMutation< | ||
| SyncRemoteTableMutation, | ||
| SyncRemoteTableMutationVariables | ||
|
|
@@ -37,20 +37,19 @@ export const useSyncRemoteTable = () => { | |
| variables: { | ||
| input, | ||
| }, | ||
| update: (cache, { data }) => { | ||
| if (isDefined(data)) { | ||
| modifyRemoteTableFromCache({ | ||
| cache: cache, | ||
| remoteTableName: input.name, | ||
| fieldModifiers: { | ||
| status: () => data.syncRemoteTable.status, | ||
| }, | ||
| }); | ||
| } | ||
| }, | ||
| }); | ||
|
|
||
| await refetchObjectMetadataItems(); | ||
|
There was a problem hiding this comment. @thomtrp what is this for? There was a problem hiding this comment. Without it, when you sync a table and go back to main app, you will not see the remote table displayed. You would need to refresh so it re-triggers this call. |
||
| await apolloClient.query({ | ||
| query: findManyViewsQuery, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { useCallback } from 'react'; | ||
| import { ApolloClient, useMutation } from '@apollo/client'; | ||
|
|
||
| import { SYNC_REMOTE_TABLE_SCHEMA_CHANGES } from '@/databases/graphql/mutations/syncRemoteTableSchemaChanges'; | ||
| import { modifyRemoteTableFromCache } from '@/databases/utils/modifyRemoteTableFromCache'; | ||
| import { useApolloMetadataClient } from '@/object-metadata/hooks/useApolloMetadataClient'; | ||
| import { | ||
| RemoteTableInput, | ||
| SyncRemoteTableSchemaChangesMutation, | ||
| SyncRemoteTableSchemaChangesMutationVariables, | ||
| } from '~/generated-metadata/graphql'; | ||
| import { isDefined } from '~/utils/isDefined'; | ||
| export const useSyncRemoteTableSchemaChanges = () => { | ||
ijreilly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const apolloMetadataClient = useApolloMetadataClient(); | ||
|
|
||
| const [mutate, mutationInformation] = useMutation< | ||
| SyncRemoteTableSchemaChangesMutation, | ||
| SyncRemoteTableSchemaChangesMutationVariables | ||
| >(SYNC_REMOTE_TABLE_SCHEMA_CHANGES, { | ||
| client: apolloMetadataClient ?? ({} as ApolloClient<any>), | ||
|
There was a problem hiding this comment. The fallback empty object cast for |
||
| }); | ||
|
|
||
| const syncRemoteTableSchemaChanges = useCallback( | ||
| async (input: RemoteTableInput) => { | ||
| const remoteTable = await mutate({ | ||
| variables: { | ||
| input, | ||
| }, | ||
| update: (cache, { data }) => { | ||
| if (isDefined(data)) { | ||
| modifyRemoteTableFromCache({ | ||
| cache: cache, | ||
| remoteTableName: input.name, | ||
| fieldModifiers: { | ||
| schemaPendingUpdates: () => | ||
| data.syncRemoteTableSchemaChanges.schemaPendingUpdates || [], | ||
| }, | ||
| }); | ||
| } | ||
| }, | ||
| }); | ||
|
|
||
| return remoteTable; | ||
| }, | ||
| [mutate], | ||
| ); | ||
|
|
||
| return { | ||
| syncRemoteTableSchemaChanges, | ||
| isLoading: mutationInformation.loading, | ||
| }; | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Check if we have an issue when we migrate between the show page of two databases that have a table with the same name. If so we could add connectionId to the cache id to make it unique