Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4655 batch endpoints on the rest api #5411

Merged
merged 28 commits into from
May 16, 2024
Merged

4655 batch endpoints on the rest api #5411

merged 28 commits into from
May 16, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented May 14, 2024 •
edited
Loading

  • add POST rest/batch/ endpoint
  • rearrange rest api code with Twenty quality standard
  • unify REST API error format
  • Added PATCH verb to update objects
  • In openapi schema, we replaced PUT with PATCH verb to comply with REST standard
  • fix openApi schema to match the REST api

    • Batch Create

    image

    Replace PUT by PATCH in open Api

    image

    Error format unification

    image
    image
    image

@martmull martmull linked an issue May 14, 2024 that may be closed by this pull request
Batch endpoints on the REST API #4655
Closed
@martmull martmull marked this pull request as ready for review May 15, 2024 11:39
@martmull martmull force-pushed the 4655-batch-endpoints-on-the-rest-api branch from e073611 to 6981d82 Compare May 15, 2024 11:59
charlesBochet
charlesBochet reviewed May 15, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good to me, added minor comments

packages/twenty-server/src/engine/api/rest/controllers/core-batch.controller.ts Outdated Show resolved Hide resolved
.../twenty-server/src/engine/api/rest/core-query-builder/factories/create-many-query.factory.ts Outdated Show resolved Hide resolved
packages/twenty-server/src/engine/api/rest/core-query-builder/utils/get-field-type.utils.ts Outdated Show resolved Hide resolved
packages/twenty-server/src/engine/api/rest/controllers/core-batch.controller.ts Outdated Show resolved Hide resolved
FelixMalfait
FelixMalfait approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Made comments on Discord.
Just a 500 to fix when sending data that isn't properly formatted

@martmull martmull force-pushed the 4655-batch-endpoints-on-the-rest-api branch from 2e264dd to e2dcde7 Compare May 16, 2024 08:48
@martmull martmull merged commit fdf10f1 into main May 16, 2024
5 checks passed
@martmull martmull deleted the 4655-batch-endpoints-on-the-rest-api branch May 16, 2024 12:15
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
@martmull
4655 batch endpoints on the rest api (twentyhq#5411)
4dd0a93 
- add POST rest/batch/<OBJECT> endpoint
- rearrange rest api code with Twenty quality standard
- unify REST API error format
- Added PATCH verb to update objects
- In openapi schema, we replaced PUT with PATCH verb to comply with REST
standard
- fix openApi schema to match the REST api

### Batch Create

![image](https://github.com/twentyhq/twenty/assets/29927851/fe8cd91d-7b35-477f-9077-3477b57b054c)

### Replace PUT by PATCH in open Api

![image](https://github.com/twentyhq/twenty/assets/29927851/9a95060d-0b21-4a04-a3fa-c53390897b5b)

### Error format unification

![image](https://github.com/twentyhq/twenty/assets/29927851/f47dfcef-a4f8-4f93-8504-22f82a8d8057)

![image](https://github.com/twentyhq/twenty/assets/29927851/d76a87e2-2bf6-4ed9-a142-71ad7c123beb)

![image](https://github.com/twentyhq/twenty/assets/29927851/6db59ad3-0ba7-4390-a02d-be15884e2516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet left review comments

@FelixMalfait FelixMalfait FelixMalfait approved these changes

Assignees

@FelixMalfait FelixMalfait

Labels
-PR: awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch endpoints on the REST API
3 participants
@martmull @FelixMalfait @charlesBochet