4002 prevent user from creating twice the same blocklist item #5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me-blocklist-item
Weiko
reviewed
Apr 30, 2024
| @@ -62,7 +62,7 @@ export interface UpdateManyResolverArgs< | |||
| Filter = any, | |||
| > { | |||
| filter: Filter; | |||
| data: Data; | |||
| data: Data[]; | |||
There was a problem hiding this comment.
data should not be an array here, this is how we use it
{
"filter": {"id": {"in": ["something", "something-else"]}},
"data": {
"name": "eae"
}
}
where data is the shape of what you want to update against all the records that match with the filters
|
|
||
| assertMutationNotOnRemoteObject(objectMetadataItem); | ||
| assertIsValidUuid(args.data.id); | ||
| for (const record of args.data) { | ||
| assertIsValidUuid(record.id); |
There was a problem hiding this comment.
This was already wrong before but we don't want to check the id from data here but from the filter object. In fact, we should reject / not return id in the data type because we don't want to allow update of the ids in an updateMany (nor in an updateOne but for the updateMany won't even work due to unicity constraint)
FYI @charlesBochet @magrinj
Weiko
deleted the
4002-prevent-user-from-creating-twice-the-same-blocklist-item
branch
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4002