[feat][Remote objects] Edit a connection (for pg) #5210
Conversation
| @@ -9,8 +9,8 @@ export type InfoAccent = 'blue' | 'danger'; | |||
| export type InfoProps = { | |||
There was a problem hiding this comment.
In a later PR I will update this component for it to be better responsive + add color variation for dark mode
| @@ -143,7 +144,7 @@ const TextInputV2Component = ( | |||
| {label && <StyledLabel>{label + (required ? '*' : '')}</StyledLabel>} | |||
| <StyledInputContainer> | |||
| <StyledInput | |||
| autoComplete="off" | |||
| autoComplete={autoComplete || 'off'} | |||
There was a problem hiding this comment.
Seeking to disable autocomplete here as it does not make sense for the db and will overwrite the default values from data.
"off" was not working (maybe it's not doing what I think it tries to do - as I don't see why we would want to always disable autocomplete?).
(...)
For this reason, many modern browsers do not support autocomplete="off" for login fields:
If a site sets autocomplete="off" for a form, and the form includes username and password input fields, then the browser still offers to remember this login, and if the user agrees, the browser will autofill those fields the next time the user visits the page.
If a site sets autocomplete="off" for username and password fields, then the browser still offers to remember this login, and if the user agrees, the browser will autofill those fields the next time the user visits the page.
| @@ -14,7 +14,7 @@ const StyledWrapper = styled.nav` | |||
| font-size: ${({ theme }) => theme.font.size.lg}; | |||
| font-weight: ${({ theme }) => theme.font.weight.semiBold}; | |||
| gap: ${({ theme }) => theme.spacing(2)}; | |||
| line-height: ${({ theme }) => theme.text.lineHeight.md}; | |||
| line-height: ${({ theme }) => theme.text.lineHeight.lg}; | |||
There was a problem hiding this comment.
Im aware this will change Breadcrumb lineheight everywhere but I think its a good thing as the Breadcrumb currently slightly glitches everywhere there is a save section on the same line:
glitch.mov
ijreilly
changed the title
...s/twenty-front/src/pages/settings/integrations/SettingsIntegrationEditDatabaseConnection.tsx
Outdated
Show resolved
Hide resolved
...s/twenty-front/src/pages/settings/integrations/SettingsIntegrationEditDatabaseConnection.tsx
Outdated
Show resolved
Hide resolved
...s/twenty-front/src/pages/settings/integrations/SettingsIntegrationEditDatabaseConnection.tsx
Outdated
Show resolved
Hide resolved
| id: connectionId, | ||
| }); | ||
|
|
||
| navigate( |
There was a problem hiding this comment.
TODO in a later PR - when redirecting to this page, connection status is not updated
Enregistrement.de.l.ecran.2024-04-29.a.16.01.50.mov
Following #5210 --------- Co-authored-by: Charles Bochet <[email protected]>
## Context twentyhq#4774 ## How was it tested Locally ## In further PRs - Update connection status upon page change - Adapt Info banner to dark mode - placeholders for form
Following twentyhq#5210 --------- Co-authored-by: Charles Bochet <[email protected]>
Context
#4774
How was it tested
Locally
In further PRs