Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sentry captureException for global error logging #5198

Merged

Conversation

shubham-kumar10
Copy link
Contributor

I have added error logging to Sentry using Sentry.captureException. The _info object which includes the componentStack will be sent in extra data along with the exception.

Copy link

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

TODOs/FIXMEs:

  • // TODO: log error to Sentry: packages/twenty-front/src/modules/error-handler/components/AppErrorBoundary.tsx

Generated by 🚫 dangerJS against 4d7cef9

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @shubham-kumar10!

@Weiko Weiko merged commit a064708 into twentyhq:main Apr 29, 2024
7 of 8 checks passed
@shubham-kumar10
Copy link
Contributor Author

LGTM. Thank you @shubham-kumar10!

@Weiko
This was related to this issue. Can you close it too so that no one picks it up?

@Weiko
Copy link
Member

Weiko commented Apr 29, 2024

Done @shubham-kumar10

arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
…#5198)

I have added error logging to Sentry using Sentry.captureException. The
_info object which includes the componentStack will be sent in extra
data along with the exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants