Add a cache on /metadata #5189
Merged
Add a cache on /metadata #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
approved these changes
Apr 26, 2024
This was referenced Apr 26, 2024
Weiko
added a commit
that referenced
this pull request
Apr 26, 2024
## Context @lucasbordeau introduced a new Yoga plugin that allows us to cache our requests (👏), see #5189 I'm simply updating the implementation to allow us to use different cache storage types such as redis Also adding a check so it does not use cache for other operations than ObjectMetadataItems ## Test locally, first call takes 340ms, 2nd takes 30ms with 'redis' and 13ms with 'memory'
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
In this PR I'm introducing a simple custom graphql-yoga plugin to create a caching mechanism specific to our metadata. The cache key is made of : workspace id + workspace cache version, with this the cache is automatically invalidated each time a change is made on the workspace metadata.
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
## Context @lucasbordeau introduced a new Yoga plugin that allows us to cache our requests (👏), see twentyhq#5189 I'm simply updating the implementation to allow us to use different cache storage types such as redis Also adding a check so it does not use cache for other operations than ObjectMetadataItems ## Test locally, first call takes 340ms, 2nd takes 30ms with 'redis' and 13ms with 'memory'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm introducing a simple custom graphql-yoga plugin to create a caching mechanism specific to our metadata.
The cache key is made of : workspace id + workspace cache version, with this the cache is automatically invalidated each time a change is made on the workspace metadata.