updated: removed gradient from onboarding buttons #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
My apologies. I'm an overeager new developer. I saw an issue that I thought I could take on and gave it a try even though it was already assigned to someone. I tried to save it as a draft until it was appropriate for me to submit a pull request. It doesn't look like it works that way. I don't mean to step on anyone's toes or bypass your guidelines. |
|
Thank you! |
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Fixes twentyhq#5168 - Added primaryInverted and primaryInvertedHover to design system. - Changed primary button background with a gradient to inverted-flat for both light and dark themes. - Hover added to go lighter (consistent with tertiary color of +5 step on GRAY_SCALE). - Font color changed from primary to inverted. - Modified button border from light to strong. Two components are still utilizing the button with gradient background - email and chrome extension. Figma design guidelines show them to be inverted and flat (not gradient). - Should I change those as well? - Should the gradient style be removed altogether after this has been completed? Co-authored-by: Henry Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5168
Two components are still utilizing the button with gradient background - email and chrome extension.
Figma design guidelines show them to be inverted and flat (not gradient).