Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load all data on record boards #5070

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Load all data on record boards #5070

merged 1 commit into from
Apr 19, 2024

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Apr 19, 2024

Context

For users with many records, only the first n*60 records were loaded on board views (n being the number of visible columns). This was because of the following behavior:

  • watch for end of column visibility changes. If an end of column is visible, try to fetch more. However, watching for visbility changes is not reliable enough.

What we want

If an end of column is visible, try to fetch more. If no more records is availble in pagination, do not fetch more

@charlesBochet charlesBochet merged commit 4bd2cdd into main Apr 19, 2024
9 checks passed
@charlesBochet charlesBochet deleted the board-load-all-data branch April 19, 2024 21:39
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
## Context

For users with many records, only the first n*60 records were loaded on
board views (n being the number of visible columns). This was because of
the following behavior:
- watch for end of column visibility changes. If an end of column is
visible, try to fetch more. However, watching for visbility changes is
not reliable enough.

## What we want

If an end of column is visible, try to fetch more. If no more records is
availble in pagination, do not fetch more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant