Implemented Search Feature in Filter Menu #5068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
Weiko
reviewed
Apr 29, 2024
| @@ -25,31 +55,50 @@ export const ObjectFilterDropdownFilterSelect = () => { | |||
|
|
|||
| const setHotkeyScope = useSetHotkeyScope(); | |||
|
|
|||
| const debouncedSetSearchFilter = useDebouncedCallback(setSearchText, 100, { | |||
There was a problem hiding this comment.
I don't think we need a debounce for this as this is not querying/computing anything, let's not slow down the experience when it's not needed 👍
|
LGTM otherwise, I will update this part in another PR 👍 |
Weiko
approved these changes
Apr 29, 2024
|
@Weiko thanks for the update. |
|
I will try to remove the debounce effect in next PR. |
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4367