[fix] Support non latin characters in schema names #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijreilly
commented
Apr 19, 2024
packages/twenty-server/package.json
Outdated
| @@ -30,6 +30,7 @@ | |||
| "lodash.uniqby": "^4.7.0", | |||
| "passport": "^0.7.0", | |||
| "psl": "^1.9.0", | |||
| "transliteration": "^2.3.5", | |||
There was a problem hiding this comment.
Weiko
reviewed
Apr 22, 2024
packages/twenty-front/src/pages/settings/data-model/utils/format-string.util.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/utils/validate-string.utils.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/utils/__tests__/validate-string.spec.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Apr 23, 2024
| @@ -1,4 +1,4 @@ | |||
| const metadataLabelValidationPattern = /^[a-zA-Z][a-zA-Z0-9 ]*$/; | |||
| const metadataLabelValidationPattern = /^[^0-9].*$/; | |||
There was a problem hiding this comment.
@ijreilly with this regex we don't exclude special characters which will also break in the BE for field creations
|
|
||
| const VALID_STRING_PATTERN = /^[a-zA-Z][a-zA-Z0-9 ]*$/; | ||
|
|
||
| export const formatMetadataLabel = (string: string): string => { |
There was a problem hiding this comment.
Actually maybe formatMetadataLabelToMetadataName is more explicit? Wdyt
| @@ -0,0 +1,9 @@ | |||
| import { InvalidStringException } from 'src/engine/metadata-modules/errors/InvalidStringException'; | |||
|
|
|||
| const VALID_STRING_PATTERN = /^[a-zA-Z][a-zA-Z0-9 ]*$/; | |||
There was a problem hiding this comment.
Looks like the pattern here is not the same as the FE pattern
Weiko
approved these changes
Apr 23, 2024
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Fixes twentyhq#4943 ## How was it tested? Local (front + /metadata) Unit tests for utils --------- Co-authored-by: Weiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4943
How was it tested?
Local (front + /metadata)
Unit tests for utils