Fixed date picker UI that was too overloaded #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbordeau
changed the title
lucasbordeau
changed the title
lucasbordeau
changed the title
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Date picker UI was off because of the recent refactor with new field types Date and DateTime. We had to allow the date picker to edit both. In this PR we come back to the previous design and we only use the input to modify time. Also we use our Select component instead of the ones from the library `react-datepicker` --------- Co-authored-by: Weiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date picker UI was off because of the recent refactor with new field types Date and DateTime. We had to allow the date picker to edit both.
In this PR we come back to the previous design and we only use the input to modify time.
Also we use our Select component instead of the ones from the library
react-datepicker