Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calendar/messaging] fix google refresh token transaction #4989

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Apr 16, 2024

Context

The full-sync job was enqueued within a transaction, which means it could be executed before the transaction was commit and connected-account was not created yet.
This PR re-arrange the code a bit to avoid this

cc @bosiraphael thx for flagging this!

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@bosiraphael bosiraphael merged commit 4bf2378 into main Apr 16, 2024
5 checks passed
@bosiraphael bosiraphael deleted the c--fix-google-refresh-token-transaction branch April 16, 2024 13:06
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
)

## Context
The full-sync job was enqueued within a transaction, which means it
could be executed before the transaction was commit and
connected-account was not created yet.
This PR re-arrange the code a bit to avoid this

cc @bosiraphael thx for flagging this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants