Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4283 create calendareventattendee data model #4333

Merged
merged 10 commits into from
Mar 6, 2024

Conversation

bosiraphael
Copy link
Contributor

Closes #4283

@bosiraphael bosiraphael linked an issue Mar 6, 2024 that may be closed by this pull request
@bosiraphael bosiraphael requested a review from Weiko March 6, 2024 11:18
description: 'Is Organizer',
icon: 'IconUser',
})
isOrganizer: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was not needed in the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe needed for the way we display events (first person to appear on the right)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm with @Bonapara? The closest thing to this field would be "role" inside messageParticipant where we need to display from/to/bcc/etc differently but here I'm not sure

Copy link
Member

@Weiko Weiko Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed offline, ok lgtm

description: 'Response Status',
icon: 'IconUser',
})
responseStatus: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create an enum here too? Also I feel like "response" is not really clear, is it "availability status" or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Availability is another concept, it could be interpreted as "is the person available" rather than "is the person coming to the event"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Availability is another concept, it could be interpreted as "is the person available" rather than "is the person coming to the event"

That's true 👍 @bosiraphael

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bosiraphael bosiraphael merged commit 577de72 into main Mar 6, 2024
14 of 15 checks passed
@bosiraphael bosiraphael deleted the 4283-create-calendareventattendee-data-model branch March 6, 2024 17:05
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
* add person relation

* add workspaceMember relation

* done

* update channel

* update event data-model

* add relation

* done

* changes after review

* update model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create calendarEventAttendee data model
2 participants