-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4283 create calendareventattendee data model #4333
4283 create calendareventattendee data model #4333
Conversation
...r/src/workspace/workspace-sync-metadata/standard-objects/calendar-channel.object-metadata.ts
Outdated
Show resolved
Hide resolved
description: 'Is Organizer', | ||
icon: 'IconUser', | ||
}) | ||
isOrganizer: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was not needed in the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe needed for the way we display events (first person to appear on the right)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we confirm with @Bonapara? The closest thing to this field would be "role" inside messageParticipant where we need to display from/to/bcc/etc differently but here I'm not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed offline, ok lgtm
description: 'Response Status', | ||
icon: 'IconUser', | ||
}) | ||
responseStatus: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create an enum here too? Also I feel like "response" is not really clear, is it "availability status" or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Availability is another concept, it could be interpreted as "is the person available" rather than "is the person coming to the event"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also responseStatus on outlook api: https://learn.microsoft.com/en-us/graph/api/resources/responseStatus?view=graph-rest-1.0#json-representation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Availability is another concept, it could be interpreted as "is the person available" rather than "is the person coming to the event"
That's true 👍 @bosiraphael
...ver/src/workspace/workspace-sync-metadata/standard-objects/calendar-event.object-metadata.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add person relation * add workspaceMember relation * done * update channel * update event data-model * add relation * done * changes after review * update model
Closes #4283