Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper ORM and postgres support #3978

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

charlesBochet
Copy link
Member

In this PR:

  • I have used this to test drizzle in production for my own knowledge :p
  • introduce DATABASE_DRIVER = 'sqlite' | 'pg'. Drizzle does not support a common API for sqlite and postgres, leading to switch cases in the code. I honestly think we should either: 1) only go with postgres and embrace drizzle API or 2) migrate to prisma or typeORM if they provide a common API
  • I've removed all raw queries (which might change a bit the calculations)
  • I've introduce migrations

Copy link

github-actions bot commented Feb 14, 2024

Warnings
⚠️ Changes were made to the environment variables, but not to the documentation - Please review your changes and check if a change needs to be documented!

Generated by 🚫 dangerJS against 8d21f94

@charlesBochet charlesBochet merged commit 4613f64 into main Feb 14, 2024
14 of 15 checks passed
@charlesBochet charlesBochet deleted the add-postgres-support branch February 14, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants