Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH 3365 Add contributors page on twenty-website #3745

Merged
merged 20 commits into from
Feb 5, 2024

Conversation

i-am-chitti
Copy link
Contributor

Description

This PR adds contributor listing page and single contributor page.
Design - https://www.figma.com/file/aNpCjwN9wg2DqLWAHPS0ll/%F0%9F%8C%8D-Twenty---Website?node-id=5%3A4973&mode=dev

Issues

Screenshots

image image image image image

Screencast

https://drive.google.com/file/d/1lMrIPK4WmckMuImjOsgBGBVJasqdoiVO/view?usp=drive_link

Note/Technical Choices

  1. The header for contributors page is different from what's globally available. To make them same, we would require to remove this custom heaader check - https://github.com/twentyhq/twenty/blob/main/packages/twenty-website/src/app/components/HeaderDesktop.tsx#L155 and https://github.com/twentyhq/twenty/blob/main/packages/twenty-website/src/app/components/HeaderDesktop.tsx#L106 . I've made them same as was referred in design.
  2. On mobile device, I'm trying to set icon dimension but the styles doesn't apply - code here. Not sure how we can handle this. Due to this there will be difference in icon sizes.
  3. Instead of displaying all PRs on single contributor page, I'm limiting them to 10.
  4. The calendar in ActivityLog component being used is not currently responsive in case there are lots of activity. I've tried several times to make it responsive across all devices like desktop, mobile and tab. But, it's lacking the feature. Also, there is no way we can remove the weekdays appearing on left side. There is a prop name weekdayLegendOffset but it's not reliable as we'll be stripping the activity parts and there are some pages where a small part of text is still visible.
Screenshot 2024-02-01 at 2 06 48 AM image

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

@FelixMalfait FelixMalfait merged commit 8dda4b0 into twentyhq:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Contributors Page for Twenty Website
2 participants