-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH 3365 Add contributors page on twenty-website #3745
Merged
FelixMalfait
merged 20 commits into
twentyhq:main
from
i-am-chitti:GH-3365/contributors-page
Feb 5, 2024
Merged
GH 3365 Add contributors page on twenty-website #3745
FelixMalfait
merged 20 commits into
twentyhq:main
from
i-am-chitti:GH-3365/contributors-page
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixMalfait
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds contributor listing page and single contributor page.
Design - https://www.figma.com/file/aNpCjwN9wg2DqLWAHPS0ll/%F0%9F%8C%8D-Twenty---Website?node-id=5%3A4973&mode=dev
Issues
Screenshots
Screencast
https://drive.google.com/file/d/1lMrIPK4WmckMuImjOsgBGBVJasqdoiVO/view?usp=drive_link
Note/Technical Choices
ActivityLog
component being used is not currently responsive in case there are lots of activity. I've tried several times to make it responsive across all devices like desktop, mobile and tab. But, it's lacking the feature. Also, there is no way we can remove the weekdays appearing on left side. There is a prop nameweekdayLegendOffset
but it's not reliable as we'll be stripping the activity parts and there are some pages where a small part of text is still visible.