Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change RecordShowPage Relation Card field display for TO_ONE_OB… #3596

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: change RecordShowPage Relation Card field display for TO_ONE_OB… #3596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54bf5a3
feat: change RecordShowPage Relation Card field display for TO_ONE_OB…
thaisguigon Jan 23, 2024
cf3b8bc
Merge branch 'main' into feat/show-page-one-object-relation
charlesBochet Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions .../modules/object-record/record-relation-card/components/RecordRelationFieldCardSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import qs from 'qs';
import { useRecoilValue } from 'recoil';

import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
import { parseFieldRelationType } from '@/object-metadata/utils/parseFieldRelationType';
import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
import { FieldContext } from '@/object-record/record-field/contexts/FieldContext';
import { usePersistField } from '@/object-record/record-field/hooks/usePersistField';
Expand All @@ -19,7 +18,7 @@ import { useRelationPicker } from '@/object-record/relation-picker/hooks/useRela
import { RelationPickerScope } from '@/object-record/relation-picker/scopes/RelationPickerScope';
import { EntityForSelect } from '@/object-record/relation-picker/types/EntityForSelect';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { IconForbid, IconPlus } from '@/ui/display/icon';
import { IconForbid, IconPencil, IconPlus } from '@/ui/display/icon';
import { useIcons } from '@/ui/display/icon/hooks/useIcons';
import { LightIconButton } from '@/ui/input/button/components/LightIconButton';
import { Card } from '@/ui/layout/card/components/Card';
Expand Down Expand Up @@ -121,6 +120,7 @@ export const RecordRelationFieldCardSection = () => {
>(recordStoreFamilySelector({ recordId: entityId, fieldName }));

const isToOneObject = relationType === 'TO_ONE_OBJECT';
const isFromManyObjects = relationType === 'FROM_MANY_OBJECTS';

const relationRecords: ObjectRecord[] =
fieldValue && isToOneObject
Expand Down Expand Up @@ -184,13 +184,11 @@ export const RecordRelationFieldCardSection = () => {
<StyledHeader isDropdownOpen={isDropdownOpen}>
<StyledTitle>
<StyledTitleLabel>{fieldDefinition.label}</StyledTitleLabel>
{parseFieldRelationType(relationFieldMetadataItem) ===
'TO_ONE_OBJECT' &&
relationRecords.length > 0 && (
<StyledLink to={filterLinkHref}>
All ({relationRecords.length})
</StyledLink>
)}
{isFromManyObjects && (
<StyledLink to={filterLinkHref}>
All ({relationRecords.length})
</StyledLink>
)}
</StyledTitle>
<DropdownScope dropdownScopeId={dropdownId}>
<StyledAddDropdown
Expand All @@ -200,7 +198,7 @@ export const RecordRelationFieldCardSection = () => {
clickableComponent={
<LightIconButton
className="displayOnHover"
Icon={IconPlus}
Icon={isToOneObject ? IconPencil : IconPlus}
accent="tertiary"
/>
}
Expand Down
Loading