feat: set field as custom object label identifier in Object Detail #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaisguigon
force-pushed
the
feat/set-field-as-label-identifier
branch
from
8f01936 to
e54ea44
Compare
thaisguigon
added
-PR: awaiting review
and removed
-PR: wip
-PR: awaiting author
labels
thaisguigon
force-pushed
the
feat/set-field-as-label-identifier
branch
from
51dc07d to
21b52fb
Compare
| field.id === objectMetadataItem.labelIdentifierFieldMetadataId || | ||
| field.name === 'name', | ||
| ): FieldMetadataItem | undefined => | ||
| objectMetadataItem.fields.find((fieldMetadataItem) => |
There was a problem hiding this comment.
Can we keep the style with { return ... } ?
| onClick={handleDisable} | ||
| /> | ||
| </Section> | ||
| {!isLabelIdentifierField({ |
There was a problem hiding this comment.
Can we extract this in a variable above ?
|
There a strange behavior with setting the record label identifier on another field, should we address this in this ticket ? Enregistrement.de.l.ecran.2024-01-16.a.17.02.41.mov |
Hi, thank you for the review! I was planning to address the Tables side with this issue: #3303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3302
TODO: