Embrace nx monorepo structure with root package.json #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
changed the title
thaisguigon
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moving all dependencies to the main package.json as recommended per nx https://nx.dev/concepts/more-concepts/dependency-management
Also: bumping our node version to 18.17.1
Note: It is still possible to override a package version in a specific workspace by adding it to the workspace package.json
Why
This will push us to use the same version of packages accross our workspaces.
Also we will benefit from nx migration features when we change package version
What I have tested
Local Setup:
Docker Setup:
Image size is 1.5GB
Dependency size is 2.2GB total
Total 3.7GB, better than before!
Github CI
Docker prod build: