Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Relation Field Card plus button in Show Page #3229

Merged
merged 1 commit into from
Jan 9, 2024
Merged

feat: add Relation Field Card plus button in Show Page #3229

merged 1 commit into from
Jan 9, 2024

Conversation

thaisguigon
Copy link
Contributor

Closes #3124

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

TODOs/FIXMEs:

  • // TODO: refactor useFilteredSearchEntityQuery: packages/twenty-front/src/modules/companies/components/OpportunityPicker.tsx
  • // TODO: refactor useFilteredSearchEntityQuery: packages/twenty-front/src/modules/object-record/relation-picker/components/RelationPicker.tsx
  • // TODO: refactor useFilteredSearchEntityQuery: packages/twenty-front/src/modules/companies/components/NewOpportunityButton.tsx
  • // TODO: replace query hooks by useFindManyRecords: packages/twenty-front/src/modules/search/hooks/useFilteredSearchEntityQuery.ts

Generated by 🚫 dangerJS against c3e9f62

@thaisguigon thaisguigon force-pushed the feat/display-show-page-relation-fields-as-cards branch 2 times, most recently from bc3ff85 to 6c077cc Compare January 4, 2024 10:41
Base automatically changed from feat/display-show-page-relation-fields-as-cards to main January 5, 2024 10:02
@thaisguigon thaisguigon force-pushed the feat/add-relation-field-card-plus-button branch from 55a233d to 65e2b8c Compare January 5, 2024 10:41
@thaisguigon thaisguigon marked this pull request as ready for review January 5, 2024 10:41
@thaisguigon thaisguigon force-pushed the feat/add-relation-field-card-plus-button branch from 65e2b8c to c3e9f62 Compare January 5, 2024 17:53
lucasbordeau
lucasbordeau reviewed Jan 9, 2024
View reviewed changes
...c/modules/object-record/relation-picker/components/SingleEntitySelectMenuItemsWithSearch.tsx
| 'selectedEntity'
>;

export const SingleEntitySelectMenuItemsWithSearch = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lucasbordeau lucasbordeau merged commit ed06cc0 into main Jan 9, 2024
10 of 13 checks passed
@lucasbordeau lucasbordeau deleted the feat/add-relation-field-card-plus-button branch January 9, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasbordeau lucasbordeau lucasbordeau approved these changes

Assignees

@lucasbordeau lucasbordeau

Labels
-PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Page - Relation field - Add "plus" button and Relation selector dropdown
3 participants
@thaisguigon @lucasbordeau @charlesBochet