-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3207 fix render self deploy #3221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comment :)
@@ -23,6 +23,7 @@ | |||
"typeorm:migrate": "yarn typeorm migration:run -d ./src/database/typeorm/metadata/metadata.datasource.ts && yarn typeorm migration:run -d ./src/database/typeorm/core/core.datasource.ts", | |||
"database:init": "yarn database:setup && yarn database:seed:dev", | |||
"database:setup": "npx ts-node ./scripts/setup-db.ts && yarn database:migrate", | |||
"database:setup:prod": "npx ts-node ./scripts/setup-db.ts && yarn typeorm:migrate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you also seed in this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we said we should not seed. Seeds are run when a workspace is created so we don't need them here i beleive
Close #3207