-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behaviour Fix on new record addition #3113
Behaviour Fix on new record addition #3113
Conversation
Hi @charlesBochet @Bonapara Screen.Recording.2023-12-22.at.12.23.11.PM.movP.S: I don't know why its giving apollo error. Ig on click outside persistField function is being called which needs to be changed later. |
The behavior works well! However, the floating input appears cropped in the cell. |
Umm I don't think so that problem arised due to this change of code. I'll create another issue for that to check the problem. |
Hi @FelixMalfait |
I agree it's not linked to your changes @Kanav-Arora. @Kanav-Arora setting back to "waiting for review", someone should review it on Monday. Sorry for the delay |
@Kanav-Arora I'm taking a look tomorrow morning! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kanav-Arora we used your PR to add refacto on top! Sorry about that!
Thanks for the contribution!
Closes #3069
I have created a function which accepts the index instead of hardcoding it just for
(0,0)
it accepts row and column as parameters so that it can be used in future to toggle edit mode of specific cells.I had to call this directly without useTableCell api because createObject doesn't have a scope but ig its working perfectly.