feat: add Settings/Accounts/New section with empty state #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thaisguigon |
thaisguigon
previously requested changes
Dec 15, 2023
| title="New account" | ||
| description="Connect a new account to your workspace" | ||
| /> | ||
| <SettingsAccountsEmptyStateCard /> |
There was a problem hiding this comment.
As you mentioned here: #2894 (comment)
We want to display "Connect a Google account" instead of "No connected account" for this section.
Could you add an optional "label" prop to this component, that overrides the "No connected account" default label when defined, and then pass "Connect a Google account" as the label?
|
Also, please rebase on main to get all the CIs back to green (we have fixed them recently) :) |
…broken (twentyhq#2911) * On RecordTable, if I have no records, the Record Table Layout is not broken Co-authored-by: v1b3m <[email protected]> Co-authored-by: RubensRafael <[email protected]> * Revert scrollbar changes Co-authored-by: v1b3m <[email protected]> Co-authored-by: RubensRafael <[email protected]> * fix + button Co-authored-by: v1b3m <[email protected]> Co-authored-by: RubensRafael <[email protected]> * Revert unwanted changes Co-authored-by: v1b3m <[email protected]> Co-authored-by: RubensRafael <[email protected]> * Merge main Co-authored-by: Thiago Nascimbeni <[email protected]> Co-authored-by: v1b3m <[email protected]> Co-authored-by: RubensRafael <[email protected]> * On RecordTable, if I have no records, the Record Table Layout is not broken Co-authored-by: v1b3m <[email protected]> Co-authored-by: Thiago Nascimbeni <[email protected]> Co-authored-by: RubensRafael <[email protected]> * Add bottom border Co-authored-by: v1b3m <[email protected]> Co-authored-by: Thiago Nascimbeni <[email protected]> Co-authored-by: RubensRafael <[email protected]> * Always show + button Co-authored-by: v1b3m <[email protected]> Co-authored-by: Thiago Nascimbeni <[email protected]> Co-authored-by: RubensRafael <[email protected]> * Refactor according to review Co-authored-by: v1b3m <[email protected]> Co-authored-by: Thiago Nascimbeni <[email protected]> Co-authored-by: RubensRafael <[email protected]> * Fix according to PR --------- Co-authored-by: gitstart-twenty <[email protected]> Co-authored-by: v1b3m <[email protected]> Co-authored-by: RubensRafael <[email protected]> Co-authored-by: Charles Bochet <[email protected]> Co-authored-by: Thiago Nascimbeni <[email protected]> Co-authored-by: Lucas Bordeau <[email protected]>
* Add jest tests for twenty-front Co-authored-by: v1b3m <[email protected]> * Fix tests --------- Co-authored-by: gitstart-twenty <[email protected]> Co-authored-by: v1b3m <[email protected]> Co-authored-by: Charles Bochet <[email protected]>
Closes twentyhq#2347 Co-authored-by: Thais GUIGON <[email protected]>
* remaining UI docs * completed ui component docs --------- Co-authored-by: Charles Bochet <[email protected]>
* Fix CIs * Fix docs * Fix eslint-build * Move file * Move back * Fix server ci * Fix server ci * Fix server ci * Fix server ci * Deactivate e2e tests * Fix front * Fix front * Fix front * Add twenty-zapier and twenty-utils to the yarn project * fix * fix * Remove pull_request trigger
Disable Danger CI on main
* feat: add Show Page Emails tab Closes twentyhq#2926, Closes twentyhq#2927 * feat: review - disable Emails tab if messaging not enabled * refactor: review - add FeatureFlagKey type --------- Co-authored-by: Thais GUIGON <[email protected]>
…q#2993) * create empty service * getting threads is working * insert message channel * save threads in the db * clean * fetch messages * create a service to fetch a batch of messages * batch messages * use httpService instead * parse batch * base 64 decoding working * solve parsing bug * saving messages is working * bug to fix in fetchAllByBatches * fetching all messages is working but not saving yet * fecth 500 messages and threads is working * remove unused package and console log * set direction to incoming * fix bug after merging main
- fix modified files
* feat: add Show Page Emails preview Closes twentyhq#2928 * refactor: review - rename StyledContainer to StyledCardContent
* Init rest-api page * Add ugly form to fetch open api schema * Clean code * Make the form design more acceptable * Update doc * Use local storage * Update design * Add isLoading * Fix typo * Fix long lines * Code review returns * Remove staging and local url from servers
* 2982-feat: Clear SelectableList reset scoped state * State fixes as suggested in pr * State fixes as suggested in pr --------- Co-authored-by: Lucas Bordeau <[email protected]> Co-authored-by: Charles Bochet <[email protected]>
…und) (twentyhq#3033) * Fix docusaurus style overriden by spotlight/element (rest api playground) * Fix spacing * Fix spacing
Co-authored-by: 曹志浩 <[email protected]> Co-authored-by: Charles Bochet <[email protected]>
|
@thaisguigon |
|
@charlesBochet |
charlesBochet
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to the Settings/Accounts/New page a "New Account" section with a title, a description, and a card.
![Uploading Screenshot 2023-12-15 at 3.21.50 PM.png…]()
And Reused the empty state card