Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimistic rendering #2882

Merged
merged 6 commits into from
Dec 9, 2023
Merged

Fix optimistic rendering #2882

merged 6 commits into from
Dec 9, 2023

Conversation

charlesBochet
Copy link
Member

This PR is providing multiple changes:

  1. Start enhancing useGenerateEmptyRecord hook to take an input as a parameter. I think generateEmptyRecord is badly named but I am not sure how we should name it: I'm leaning toward generateCompleteRecord(partialInput: Partial). We will revisit it next week when we implement a complete logic. Right now I'm hardcoding the logic for company, person and opportunity to see how this is behaving.

  2. Fixing Optimistic rendering issue on Opportunity (the opportunity was spawning in the wrong column with wrong name)

  3. Fixing optimistic rendering issue on Person / Company record table (the date was wrong)

  4. Fixing optimistic rendering issue on Tasks (wip)

  5. Fixing optimistic rendering issue on Object Field creation (wip)

Copy link

github-actions bot commented Dec 8, 2023

TODOs/FIXMEs:

  • // Todo fix typing: front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx
  • // Todo fix typing: front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx
  • // Todo fix typing: front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx
  • // Todo fix typing once we generate the return base on Metadata: front/src/modules/object-record/hooks/useGenerateEmptyRecord.ts
  • // Todo replace this by runtime typing: front/src/modules/object-record/hooks/useGenerateEmptyRecord.ts

Generated by 🚫 dangerJS against 75d8c8d

@charlesBochet charlesBochet merged commit 9d4ed32 into main Dec 9, 2023
7 of 8 checks passed
@charlesBochet charlesBochet deleted the fix-optimistic-rendering branch December 9, 2023 09:38
@charlesBochet charlesBochet mentioned this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant