Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet import front module #2862

Merged
merged 7 commits into from
Dec 9, 2023
Merged

Spreadsheet import front module #2862

merged 7 commits into from
Dec 9, 2023

Conversation

gitstart-twenty
Copy link
Contributor

@gitstart-twenty gitstart-twenty commented Dec 7, 2023

Demo

import-files

Fixes #2473

Co-authored-by: v1b3m <[email protected]>
Co-authored-by: Toledodev <[email protected]>
Co-authored-by: Rafael Toledo <[email protected]>
@gitstart-twenty gitstart-twenty marked this pull request as draft December 7, 2023 14:27
Copy link

github-actions bot commented Dec 7, 2023

TODOs/FIXMEs:

  • // TODO: abstract this part for any object: front/src/modules/people/hooks/useSpreadsheetPersonImport.ts
  • // TODO : abstract this part for any object: front/src/modules/people/hooks/useSpreadsheetPersonImport.ts

Generated by 🚫 dangerJS against c0cebe1

Co-authored-by: v1b3m <[email protected]>
Co-authored-by: Toledodev <[email protected]>
Co-authored-by: Rafael Toledo <[email protected]>
@charlesBochet
Copy link
Member

@lucasbordeau Could you take a look?


const apolloClient = useApolloClient();

const createManyRecords = async (data: Record<string, any>[]) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@@ -0,0 +1,77 @@
import { Company } from '@/companies/types/Company';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is acceptable at this stage to implement a company and a person version but we will want to re-implement it for any standard or custom object in a more abstract way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@charlesBochet charlesBochet merged commit 306344a into main Dec 9, 2023
9 of 13 checks passed
@charlesBochet charlesBochet deleted the TWNTY-2473 branch December 9, 2023 10:01
@charlesBochet charlesBochet mentioned this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 - Spreadsheet import front module
3 participants