-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2426 timebox refactor board with the new scope architecture #2789
Merged
charlesBochet
merged 21 commits into
main
from
2426-timebox-refactor-board-with-the-new-scope-architecture
Dec 5, 2023
Merged
2426 timebox refactor board with the new scope architecture #2789
charlesBochet
merged 21 commits into
main
from
2426-timebox-refactor-board-with-the-new-scope-architecture
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bosiraphael
commented
Dec 1, 2023
•
edited
Loading
edited
- Renamed components, states and hooks to RecordBoard...
- Changed states to be scoped states
- Removed unnecessary Contexts and Scopes
- Created Scopes with the same architecture as RecordTable, Views ...
- Created hooks: useRecordBoard, useRecordBoardScopedStates ...
…efactor-board-with-the-new-scope-architecture
charlesBochet
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
charlesBochet
deleted the
2426-timebox-refactor-board-with-the-new-scope-architecture
branch
December 5, 2023 11:15
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.