Skip to content

chore: replace vite-tsconfig-paths with resolve.tsconfigPaths - #22100

Merged
charlesBochet merged 2 commits into
twentyhq:mainfrom
parshipcy:chore/migrate-vite8-tsconfig-paths
Jun 24, 2026
Merged

chore: replace vite-tsconfig-paths with resolve.tsconfigPaths#22100
charlesBochet merged 2 commits into
twentyhq:mainfrom
parshipcy:chore/migrate-vite8-tsconfig-paths

Conversation

@parshipcy

@parshipcy parshipcy commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrates main monorepo packages from the vite-tsconfig-paths plugin to vite’s built-in path resolution.

Vite 8 showing this warning when the plugin is detected:

The plugin "vite-tsconfig-paths" is detected. Vite now supports tsconfig paths resolution natively via the resolve.tsconfigPaths option. You can remove the plugin and set resolve.tsconfigPaths: true in your Vite config instead.

References

Review in cubic

Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com>
@twenty-ci-bot-public

Copy link
Copy Markdown

👋 Thanks for contributing to Twenty!

Your PR has been set to draft while you work on it. Once you're done, mark it as Ready for review and our automated checks will run.

Looking forward to your contribution!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 33 files

Re-trigger cubic

@charlesBochet

Copy link
Copy Markdown
Member

@parshipcy good direction but please Fix CI :)

@parshipcy
parshipcy marked this pull request as draft June 24, 2026 15:31
Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com>
@twenty-ci-bot-public

Copy link
Copy Markdown

🔍 Visual Regression Review — twenty-ui

⚠️ The Argos build errored — visual review could not run. A manual visual check is recommended (not blocking).

Changed: 0 · Added: 0 · Removed: 0


View run details · advisory mode

@parshipcy
parshipcy marked this pull request as ready for review June 24, 2026 16:12
@twenty-ci-bot-public

Copy link
Copy Markdown

🔍 Automated Pre-Review

🔴 High severity issues detected - This PR needs attention before approval.

cc @prastoin

Summary

  • 🔴 12 high/critical issue(s)

🧭 External PR Quality Review

🟠 Needs triage for the following reason(s):

  • CI is red (danger-js)
  • Not associated with an existing issue (required for external PRs)
  • Does not follow Twenty technical standards (1 issue(s))

cc @prastoin

Checks

  • CI: red — failing: danger-js
  • 📐 Standards: 1 issue(s)

Detailed findings (duplicate candidates, standards notes, summary) are in the workflow run logs.


View details

Automated pre-review — human approval still required.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 37 files

Re-trigger cubic

@twenty-ci-bot-public

Copy link
Copy Markdown

🔍 Visual Regression Review — twenty-front

✅ 6 visual change(s) reviewed — all explained by this PR.

Changed: 7 · Added: 1 · Removed: 1 · Unchanged: 673

6 item(s) to double-check (uncertain / low confidence)
Story Verdict Confidence Explained by
🟡 modules-commandmenu-commandmenu--sub-page-navigation uncertain 62%
🟡 modules-settings-accounts-blocklist-settingsaccountsblocklistinput--default uncertain 70%
🟡 pages-settings-datamodel-settingsobjectdetail--object-tabs uncertain 72%
🟡 pages-settings-datamodel-settingsobjectdetail--standard-object uncertain 72%
🟡 pages-auth-signinupv2--default uncertain 58% packages/twenty-front-component-renderer/.storybook/main.ts was changed — a Stor…
🟡 pages-settings-playground-restplayground--default uncertain 58% packages/twenty-front-component-renderer/.storybook/main.ts was changed — a Stor…
Changed stories
Story Diff %
modules-commandmenu-commandmenu--sub-page-navigation 14%
modules-settings-accounts-blocklist-settingsaccountsblocklistinput--default 1%
pages-settings-datamodel-settingsobjectdetail--object-tabs 0%
pages-settings-datamodel-settingsobjectdetail--standard-object 0%
ui-data-field-input-richtextfieldinput--default 0%
modules-objectrecord-recordcalendar-month--default 0%
pages-settings-datamodel-settingsobjects--default 0%
1 new stories
  • pages-auth-signinupv2--default

View run details · advisory mode

@charlesBochet charlesBochet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet
charlesBochet merged commit 6ee5413 into twentyhq:main Jun 24, 2026
139 of 141 checks passed
@parshipcy
parshipcy deleted the chore/migrate-vite8-tsconfig-paths branch June 24, 2026 19:07
@parshipcy parshipcy changed the title chore(vite): replace vite-tsconfig-paths with resolve.tsconfigPaths chore: replace vite-tsconfig-paths with resolve.tsconfigPaths Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants