-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Board options edit and reorder #1858
Conversation
@AdityaPimpalkar the other PR has been merged! Thanks for all your contributions! |
A few issues I am running into:
Screen.Recording.2023-10-08.at.9.58.05.PM.mov |
<BoardOptionsContext.Provider | ||
value={{ | ||
...opportunitiesBoardOptions, | ||
handleEditColumnTitle: handleEditColumnTitle, | ||
handleDeleteColumn: handlePipelineStageDelete, | ||
}} | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid too much prop drilling, I passed it into context
front/src/modules/ui/board/components/BoardOptionsDropdownContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like some feedback on this as well :)
@AdityaPimpalkar @bosiraphael I've tried to merge it but we are too far now. I'm leaving it open. We will pick and re-use the components once the Board refactoring is completed |
@AdityaPimpalkar We have not forgotten this one! We are getting there, it's likely to be tackled early next week! |
Hey @charlesBochet I can re implement this in a new PR if you want, you can close this one because there are too many conflicts |
Thank you @AdityaPimpalkar I'll likely ping you next week then! |
@AdityaPimpalkar, we have changed our product requirement on this one. In the new board implementation, you'll be able to create a board on any object having a field of type SELECT. The existing board is a board of Opportunity on field Stage. Re-ordering and changing the column will be done through Settings > Data model. We don't want to make them editable on the board directly anymore as this would confuse the users to be able to edit opportunity stages in two different places. Thanks again for the multiple contributions on Twenty! |
closes: #818
Tasks
onDragEnd
logic to avoid duplicated logicisVisible
column topipeline_stages
on the backendMenuItemTag
which rendersTag
insideMenuItem
BoardColumnEditTitleMenu
on edit