Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reorder kanban columns #1699

Merged
merged 17 commits into from
Sep 27, 2023
Merged

feat: reorder kanban columns #1699

merged 17 commits into from
Sep 27, 2023

Conversation

AdityaPimpalkar
Copy link
Contributor

closes: #1641

Screen.Recording.2023-09-21.at.6.02.58.PM.mov

AdityaPimpalkar
AdityaPimpalkar commented Sep 21, 2023
View reviewed changes
Copy link
Contributor Author

@AdityaPimpalkar AdityaPimpalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some suggestions, thanks! :)

charlesBochet
charlesBochet reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another future masterpiece, thank. you @AdityaPimpalkar

front/src/modules/ui/board/components/EntityBoardColumn.tsx Outdated Show resolved Hide resolved
front/src/modules/ui/board/hooks/useBoardColumns.ts Show resolved Hide resolved
charlesBochet
charlesBochet reviewed Sep 21, 2023
View reviewed changes
front/src/modules/ui/board/hooks/useBoardColumns.ts Outdated
(tableColumn) => tableColumn.id === column.id,
);

const targetColumnArrayIndex =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like duplicated logic with Table. Can we extract it to a common hook? useMoveViewFields() you can put it into the views folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to name this useMoveViewFields? Board columns are PipelineStages, not ViewFields, unlike Table columns. Couldn't this cause confusion in the future @charlesBochet? We could perhaps name this useMoveViewColumns for instance?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point!

@AdityaPimpalkar
Copy link
Contributor Author

AdityaPimpalkar commented Sep 24, 2023 •
edited
Loading

HooksCompanyBoardEffect was being re-rendered on state change and that hook makes a new db call on each render so my recoil state change was being replaced every time.

I found a fix, but I could use your input @charlesBochet to make it better. Thanks :)

Screen.Recording.2023-09-24.at.1.44.41.PM.mov

@AdityaPimpalkar AdityaPimpalkar marked this pull request as ready for review September 24, 2023 12:55
charlesBochet
charlesBochet approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit 46ad360 into twentyhq:main Sep 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaisguigon thaisguigon thaisguigon left review comments

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
-PR: awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement possibilty to move Kaban colomn
3 participants
@AdityaPimpalkar @thaisguigon @charlesBochet