Fix export view missing column and viewGroups not persisted bug #10584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosiraphael
approved these changes
Feb 28, 2025
| @@ -157,7 +157,7 @@ export class MigrateRichTextContentPatchCommand extends MaintainedWorkspacesMigr | |||
| return await this.featureFlagRepository.exists({ | |||
| where: { | |||
| workspaceId, | |||
| key: FeatureFlagKey.IsRichTextV2Enabled, | |||
There was a problem hiding this comment.
yes, @etiennejouan has removed the flags but still using it in the migration command
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses two key issues in the Twenty CRM platform:
- Fixes persistence of viewGroups (GroupBy feature) by removing the unnecessary
viewBarIdparameter fromuseRecordGroupVisibilityhook calls across multiple components - Resolves missing columns in export view by properly incorporating the current view ID when generating record index IDs for exports
Key changes:
- Modified
useExportMultipleRecordsAction.tsxto usegetRecordIndexIdFromObjectNamePluralAndViewIdfor correct column inclusion in exports - Updated
useDeleteMultipleRecordsAction.tsxanduseDestroyMultipleRecordsAction.tsxto use current view ID context for proper record table identification - Removed
viewBarIdparameter fromuseRecordGroupVisibilityhook calls in multiple components to fix group persistence - Changed
useSaveCurrentViewGroups.tsto retrieve current view ID from Recoil state rather than requiring it as a parameter - Modified
useRecordGroupReorder.tsto properly persist group reordering changes to the backend
12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10535
Also fixes missing columns in export view