Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input alignment fix #10577

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

ehconitin
Copy link
Contributor

this fix was already the case before this change

Unsure why this change was necessary.

Screenshot 2025-02-28 at 16 02 38

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR simplifies the InputErrorHelper component by removing a redundant isVisible prop, as the component already conditionally renders based on the existence of children.

  • Removed unnecessary isVisible prop from InputErrorHelper.tsx since the component already checks for children existence
  • Updated TextInputV2.tsx to use conditional rendering with {!noErrorHelper && error && (...)} instead of passing an isVisible prop
  • Reordered imports in InputErrorHelper.tsx for better organization (styled before React)
  • This change reverts to behavior that existed before a previous modification, fixing potential alignment issues with error messages

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@ehconitin ehconitin merged commit 85bfd87 into twentyhq:main Feb 28, 2025
45 checks passed
Copy link
Contributor

Thanks @ehconitin for your contribution!
This marks your 106th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants