Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missed search decorator #10573

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

etiennejouan
Copy link
Contributor

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added the missing @WorkspaceIsSearchable() decorator to the WorkspaceMemberWorkspaceEntity class, enabling proper search functionality for workspace members.

  • The entity already had search capabilities with a searchVector field and defined SEARCH_FIELDS_FOR_WORKSPACE_MEMBER but lacked the required decorator
  • This fix ensures workspace members will now properly appear in search results throughout the application
  • The decorator works with the existing search vector field to enable full-text search capabilities for member records

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosiraphael bosiraphael merged commit 124e694 into main Feb 28, 2025
32 of 35 checks passed
@bosiraphael bosiraphael deleted the ej/fix-workspace-member-search branch February 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants