Fix filter rest api #10537
Merged
Fix filter rest api #10537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
approved these changes
Feb 27, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the REST API filter system by standardizing on the ObjectMetadataItemWithFieldMaps type across multiple utility functions, improving both type safety and performance.
- Replaced direct array searches with map-based lookups in
check-filter-enum-values.tsandget-field-type.utils.ts, significantly improving performance for objects with many fields - Added explicit type definitions in
GetVariablesFactoryto ensure proper structure of theobjectMetadataparameter - Updated
FilterInputFactoryto correctly useobjectMetadataMapIteminstead ofobjectMetadataItemwhen callingparseFilter - Modified test files to use more comprehensive mock objects that include both
fieldsByIdandfieldsByNamemaps - Standardized parameter types across all filter-related utility functions for better consistency and maintainability
9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weiko
added a commit
that referenced
this pull request
Feb 27, 2025
## Context Rest API is now using cache metadata but the change was not done everywhere which was breaking the API <img width="953" alt="Screenshot 2025-02-27 at 10 48 31" src="https://github.com/user-attachments/assets/84f549a6-59b5-4989-b1ba-2d5c515ee47c" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Rest API is now using cache metadata but the change was not done everywhere which was breaking the API
