-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix field empty value check for Person standard object #10533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR fixes field empty value checks for the Person standard object when the labelIdentifier is a FULL_NAME field by leveraging existing utilities instead of custom logic.
- Moved components and hooks from
record-picker-morph-legacy
toactivities/inline-cell
directory for better organization - Added new
ActivityTargetInlineCellEditModeMultiRecordsSearchFilterEffect
component to handle filtering records for activity targets - Added required
componentInstanceId
prop toMultipleRecordPicker
and related components for proper state management - Added
onOpenEditMode
andonCloseEditMode
callbacks toFieldContext
andRecordInlineCellContext
to handle edit mode transitions - Created dedicated
MultiObjectRecordQueryResult
type file to separate types from implementation
Greptile AI: This PR fixes field empty value checks for the Person standard object when the labelIdentifier is a FULL_NAME field by leveraging existing utilities instead of custom logic.
- Moved components and hooks from
record-picker-morph-legacy
toactivities/inline-cell
directory for better organization - Added new
ActivityTargetInlineCellEditModeMultiRecordsSearchFilterEffect
component to handle filtering records for activity targets - Added required
componentInstanceId
prop toMultipleRecordPicker
and related components for proper state management - Added
onOpenEditMode
andonCloseEditMode
callbacks toFieldContext
andRecordInlineCellContext
to handle edit mode transitions - Created dedicated
MultiObjectRecordQueryResult
type file to separate types from implementation
29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
0112d8b
to
b1a6ed1
Compare
The previous code was not correct if labelIdentifier is a FULL_NAME. We already have an util for this Fixes: #10532
The previous code was not correct if labelIdentifier is a FULL_NAME.
We already have an util for this
Fixes: #10532