Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field empty value check for Person standard object #10533

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Feb 27, 2025

The previous code was not correct if labelIdentifier is a FULL_NAME.
We already have an util for this

Fixes: #10532

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes field empty value checks for the Person standard object when the labelIdentifier is a FULL_NAME field by leveraging existing utilities instead of custom logic.

  • Moved components and hooks from record-picker-morph-legacy to activities/inline-cell directory for better organization
  • Added new ActivityTargetInlineCellEditModeMultiRecordsSearchFilterEffect component to handle filtering records for activity targets
  • Added required componentInstanceId prop to MultipleRecordPicker and related components for proper state management
  • Added onOpenEditMode and onCloseEditMode callbacks to FieldContext and RecordInlineCellContext to handle edit mode transitions
  • Created dedicated MultiObjectRecordQueryResult type file to separate types from implementation

Greptile AI: This PR fixes field empty value checks for the Person standard object when the labelIdentifier is a FULL_NAME field by leveraging existing utilities instead of custom logic.

  • Moved components and hooks from record-picker-morph-legacy to activities/inline-cell directory for better organization
  • Added new ActivityTargetInlineCellEditModeMultiRecordsSearchFilterEffect component to handle filtering records for activity targets
  • Added required componentInstanceId prop to MultipleRecordPicker and related components for proper state management
  • Added onOpenEditMode and onCloseEditMode callbacks to FieldContext and RecordInlineCellContext to handle edit mode transitions
  • Created dedicated MultiObjectRecordQueryResult type file to separate types from implementation

29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit 2f04820 into main Feb 27, 2025
46 checks passed
@charlesBochet charlesBochet deleted the fix-field-empty-value branch February 27, 2025 09:08
charlesBochet added a commit that referenced this pull request Feb 27, 2025
The previous code was not correct if labelIdentifier is a FULL_NAME.
We already have an util for this

Fixes: #10532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a board on top of Person lead to an error
2 participants