Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export action from the view options menu #10517

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

bosiraphael
Copy link
Contributor

@bosiraphael bosiraphael commented Feb 26, 2025

Closes twentyhq/core-team-issues#64
Remove export action from the view options menu

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the export functionality from the view options menu in the ObjectOptionsDropdownMenuContent component.

  • Removed the IconFileExport import from twenty-ui
  • Removed the useExportRecords hook and its related displayedExportProgress function
  • Removed the export MenuItem from the dropdown menu options
  • Reorganized imports by moving useLingui to be grouped with other external imports
  • Kept the import functionality intact for objects that support it

Greptile AI

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@@ -166,10 +161,6 @@ export class MainPage {
await this.importButton.click();
}

async clickExportButton() {
Copy link
Contributor

@prastoin prastoin Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: You're the boss for having updated e2e tests

@bosiraphael bosiraphael merged commit 24aca79 into main Feb 26, 2025
47 checks passed
@bosiraphael bosiraphael deleted the 64-remove-export-view-from-option-menu branch February 26, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove export view from option menu
2 participants