Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed record sort on kanban #10515

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

lucasbordeau
Copy link
Contributor

This PR fixes a leftover from the removal of combined filters and sorts.

Board request hook was still relying on combinedViewSorts, here we just use currentRecordSorts instead and it works well.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed record sorting on kanban boards by replacing the outdated combined view sorts with direct usage of current record sorts.

  • Modified packages/twenty-front/src/modules/object-record/record-index/hooks/useLoadRecordIndexBoardColumn.ts to use currentRecordSortsComponentState instead of the deprecated combined view sorts
  • Removed unnecessary imports for useGetCurrentView and mapViewSortsToSorts that were no longer needed
  • Added import for currentRecordSortsComponentState to directly access the current sorting preferences
  • Implemented useRecoilComponentValueV2 to properly retrieve the current record sorts
  • Added turnSortsIntoOrderBy to convert the sorts into the proper format for GraphQL queries

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@lucasbordeau lucasbordeau enabled auto-merge (squash) February 26, 2025 15:26
@lucasbordeau lucasbordeau merged commit e6355c7 into main Feb 26, 2025
47 checks passed
@lucasbordeau lucasbordeau deleted the fix/record-board-taking-old-combined-view-sorts branch February 26, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants