Fix record page context store instance id #10508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a bug by replacing dynamic context store instance IDs with a static 'main-context-store' ID in the RecordShowPage component.
- Changed context store instance ID in
packages/twenty-front/src/pages/object-record/RecordShowPage.tsxfrom dynamicrecord-show-${objectRecordId}to static 'main-context-store' - This ensures consistent context access across the application, particularly important for components that need to interact with the record show page
- Aligns with the pattern used in
MainContextStoreProvider.tsxwhich manages context for both record index and show pages - Fixes context synchronization issues that were introduced in PR Refacto views #10272
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced by #10272