add new @WorkspaceIsSearchable decorator + updates services + add migration command #10507
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a new @WorkspaceIsSearchable decorator and isSearchable property to control which entities can be included in search results.
- Added new
isSearchableboolean column toobjectMetadatatable with migration file1740478150675-addIsSearchableColumInObjectMetadataTable.ts - Created migration command
0-43-migrate-is-searchable-for-custom-object-metadata.command.tsto setisSearchable=truefor existing custom objects - Simplified
GlobalSearchService.filterObjectMetadataItems()to use the newisSearchableproperty instead of hardcoded object types - Applied
@WorkspaceIsSearchable()decorator to standard entities (Person, Company, Note, Task, Opportunity) - Removed utility functions
isObjectMetadataItemSearchableandisObjectMetadataItemSearchableInCombinedRequestin favor of direct property checks
38 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
...ages/twenty-server/src/database/commands/upgrade-version/0-43/0-43-upgrade-version.module.ts
Outdated
Show resolved
Hide resolved
...abase/typeorm/metadata/migrations/1740478150675-addIsSearchableColumInObjectMetadataTable.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Enregistrement.de.l.ecran.2025-02-27.a.14.16.36.mov
Just ran the upgrade command. maybe I need to activate something else ?
Update: seems like upgrade command is not enough, sync-metadata must be run too. Not sure how this is usually indicated to self hosters and ppl in charge of release
| super(workspaceRepository, twentyORMGlobalManager); | ||
| } | ||
|
|
||
| async runMigrationCommandOnActiveWorkspaces( |
There was a problem hiding this comment.
we now also maintain workspaces that are not active right?
There was a problem hiding this comment.
my command extends ActiveWorkspacesMigrationCommandRunner command which expects runMigrationCommandOnActiveWorkspaces method. It is called 'active' but it includes active and suspended workspaces - all workspaces who need to be maintained.
There was a problem hiding this comment.
Ok thank you
maybe we could rename ActiveWorkspaces with MaintainedWorkspaces (or a better english term)?
you're right, not working well. @prastoin is currently fixing on the upgrade command bug that should sync-metadata. |
closes twentyhq/core-team-issues#345