add stories to roles components #10503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added Storybook stories for roles components and reorganized the component structure by moving role-related components from 'pages' to 'modules' directory.
- Added stories for
Roles,RolesDefaultRole,SettingsRoles, andSettingsRoleEditcomponents with appropriate decorators and mock data - Created new mock data in
/packages/twenty-front/src/testing/mock-data/roles.tswith Admin and Guest role examples - Added GraphQL mock for
GET_ROLESquery ingraphqlMocks.tsto support Storybook stories - Updated import paths across multiple files from
~/pages/settings/roles/...to@/settings/roles/... - Made
colorSchemeproperty required inWorkspaceMember.tstype definition
Greptile AI
29 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
.../twenty-front/src/modules/settings/roles/components/__stories__/RolesDefaultRole.stories.tsx
Show resolved
Hide resolved
.../twenty-front/src/modules/settings/roles/components/__stories__/RolesDefaultRole.stories.tsx
Outdated
Show resolved
Hide resolved
ijreilly
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding stories for roles components. Also moving modules components to the proper "modules" folder, "pages" folder being only for entry points.
Test
Run storybook