[BUGFIX] Create optimistic cache generate recordGqlFields from prefilled record
#10493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prastoin
commented
Feb 25, 2025
| @@ -102,6 +102,7 @@ export const useCreateOneRecord = < | |||
| recordInput: { | |||
| ...baseOptimisticRecordInputCreatedBy, | |||
| ...recordInput, | |||
| position: Number.NEGATIVE_INFINITY, | |||
There was a problem hiding this comment.
Review: Might be quite radical but we always want new record to be displayed on top
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a bug where newly created empty records weren't appearing in the table view due to optimistic cache issues.
- In
packages/twenty-front/src/modules/object-record/cache/hooks/useCreateOneRecordInCache.ts, the record is now prefilled before generating GraphQL fields, ensuring all required fields are included in the optimistic cache - In
packages/twenty-front/src/modules/object-record/hooks/useCreateOneRecord.ts, addedposition: Number.NEGATIVE_INFINITYto optimistic record input, ensuring new records appear in the table before server response - The changes ensure that optimistic records fulfill all mutation response field requirements, preventing them from being considered invalid
- The fix properly handles the position field which is critical for record ordering in the UI
- These changes maintain backward compatibility while addressing the specific issue where empty records weren't refreshing the view
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/object-record/cache/hooks/useCreateOneRecordInCache.ts
Show resolved
Hide resolved
charlesBochet
approved these changes
Feb 26, 2025
prastoin
added a commit
that referenced
this pull request
Feb 26, 2025
## Introduction This refactor results from this #10493 review Introduced a new abstraction to the extinsting `generateDepthOneRecordGqlFields` that was accepting an optional record in arg in order to map generated `recordGqlFields` to the keys in the record 1/ Created a dedicated util method `generateDepthOneRecordGqlFieldsFromRecord` to do so 2/ Updated each previous `generateDepthOneRecordGqlFields` passing a record to call new `generateDepthOneRecordGqlFieldsFromRecord`
prastoin
added a commit
that referenced
this pull request
Feb 26, 2025
… that has the field (#10510) # Introduction In this PR #10493 introduced a regression on optimistic cache for record creation, by expecting a `position` `fieldMetadataItem` on every `ObjectMetadataItem` which is a wrong assertion Some `Tasks` and `ApiKeys` do not have one ## Fix Dynamically compute optimistic record input position depending on current `ObjectMetadataItem` ## Refactor Refactored a failing test following [jest each](https://jestjs.io/docs/api#describeeachtablename-fn-timeout) pattern to avoid error prone duplicated env tests. Created a "standard' and applied it to an other test also using `it.each`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
The record does not appear in the table because the optimistic record input cached does not fulfill the mutation response fields, which result in it being considered as invalid response
close #10199
close #10153