Fix thread pagination

[bosiraphael]

Fixes #10308.

The issue came from the fact that the pagination inside the findAndCount wasn't working properly. The limit was applied on the joint table. Adding a groupBy fixes this, but since it isn't available on the findAndCount I had to modify the query using the query builder.

[greptile-apps]

PR Summary

This PR fixes thread pagination and duplication issues in the messaging service by replacing the findAndCount method with a more precise query builder approach.

• Implemented a two-step query process in getAndCountMessageThreads() that first gets thread IDs with proper pagination, then fetches full thread data
• Added explicit groupBy('messageThread.id') to prevent duplicates in query results
• Improved ordering with MAX(messages.receivedAt) to ensure consistent thread sorting
• Changed from using Any to In TypeORM operator for better query performance
• Fixed the load more functionality by properly applying pagination to the grouped results

Greptile AI: This PR fixes thread pagination and duplication issues in the messaging service by replacing the findAndCount method with a more precise query builder approach.

• Implemented a two-step query process in getAndCountMessageThreads() that first gets thread IDs with proper pagination, then fetches full thread data
• Added explicit groupBy('messageThread.id') to prevent duplicates in query results
• Improved ordering with MAX(messages.receivedAt) to ensure consistent thread sorting
• Changed from using Any to In TypeORM operator for better query performance
• Fixed the load more functionality by properly applying pagination to the grouped results

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[guillim]

Do you think we could add a warning like a linter rule when someone uses findandcount and join ? just thinking KAISEN style :)

[Weiko]

Do you think we could add a warning like a linter rule when someone uses findandcount and join ? just thinking KAISEN style :)

Yes!
We can change the code in the workspace repository class that extends typeorm repository since we own that part of the code. A linter rule is fine too if it's too complex 👍 @guillim

[guillim]

True. I understand your suggestion, I will try to work on that on my future "slack friday"

I guess the last thing not 100% clear to me is how to detect accuratly that the where condition is on a joint entity not on the current one. STANDBY