feat(approval-domain): add UI for approval domains #10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced start and end adornments for TextInputV2 to enhance input functionality and user experience. Updated relevant components to use TextInputV2 with adornments in the security settings page. Added styling and logic to support the adornments seamlessly.
…val-domains # Conflicts: # packages/twenty-front/src/pages/settings/security/SettingsSecurityApprovedAccessDomain.tsx
Replaced start and end adornment props with left and right adornment for consistency. Merged separate start and end adornment components into a single reusable styled component to reduce duplication and improve maintainability. Updated related usage and references across the codebase.
Introduced an optional description field for settings list items, allowing additional context or details to be displayed. Updated the approved access domains list to show relative creation dates as item descriptions. This enhances the readability and usability of settings lists.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the UI for approval domains by adding descriptive elements and improving input components for better user experience.
- Added
getItemDescriptionprop toSettingsListCardcomponent to display additional information for each list item - Implemented description display in
SettingsListItemCardContentwith styled text to visually distinguish it from labels - Enhanced
SettingsApprovedAccessDomainsListCardto show formatted creation dates as descriptions usingbeautifyPastDateRelativeToNow - Improved
TextInputV2component with left/right adornments for better visual presentation - Updated domain validation in
SettingsSecurityApprovedAccessDomainwith a more accurate regex pattern and clearer error messages
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Great! Page is not taking full height/width on my side: |
|
Sorry it's this one but both have the same issue and should be fixed: 
|
Same for the custom domain page. I check that |
Added a CSS rule to make form elements span 100% width. This resolves layout inconsistencies across different sections of the application.
|
Change "Approved Email Domain" to "Approved Domains" 
|
Renamed the section title from "Approved Email Domain" to "Approved Domains" for better clarity. This change ensures the title accurately reflects the content and functionality of the section.
| @@ -31,12 +31,40 @@ const StyledContainer = styled.div< | |||
| `; | |||
|
|
|||
| const StyledInputContainer = styled.div` | |||
| align-items: center; | |||
| background-color: inherit; | |||
| display: flex; | |||
| flex-direction: row; | |||
| position: relative; | |||
| `; | |||
|
|
|||
There was a problem hiding this comment.
Could you add it to storybook variants?
FelixMalfait
approved these changes
Feb 25, 2025
Introduce left and right adornments for TextInputV2 to enhance UI flexibility. Adjust line-height dynamically based on sizeVariant to improve visual consistency.
6 tasks
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.